From: Martin Michlmayr <tbm@cyrius.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Woody Suwalski <woody@suwalski.net>, Jan Rinze <janrinze@home.nl>
Subject: [PATCH] cyber2000fb.c: Fix 16bpp mode
Date: Thu, 8 Nov 2007 09:22:00 +0100 [thread overview]
Message-ID: <20071108082159.GB23626@deprecation.cyrius.com> (raw)
In-Reply-To: <000501c81e5e$c1334160$4399c420$@nl>
Jan Rinze noticed that 16bpp screen mode is not working on Netwinder:
"After some deduction it appeared that it was running in 24bpp instead
of 16bpp. Found the bug: a missing 'break' statement at the end of a
switch case. After adding the break statement 16bpp works fine."
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
Cc: Jan Rinze <janrinze@home.nl>
Cc: Woody Suwalski <woody@suwalski.net>
--- a/drivers/video/cyber2000fb.c
+++ b/drivers/video/cyber2000fb.c
@@ -874,6 +874,8 @@ static int cyber2000fb_set_par(struct fb_info *info)
default:
BUG();
}
+ break;
+
case 24:/* TRUECOLOUR, 16m */
hw.co_pixfmt = CO_PIXFMT_24BPP;
hw.width *= 3;
--
Martin Michlmayr
http://www.cyrius.com/
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next parent reply other threads:[~2007-11-08 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000501c81e5e$c1334160$4399c420$@nl>
2007-11-08 8:22 ` Martin Michlmayr [this message]
2007-11-08 13:03 ` [PATCH] cyber2000fb.c: Fix 16bpp mode Woody
2007-11-10 16:52 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071108082159.GB23626@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=janrinze@home.nl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=woody@suwalski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).