* [PATCH] cyber2000fb.c: Fix 16bpp mode
[not found] <000501c81e5e$c1334160$4399c420$@nl>
@ 2007-11-08 8:22 ` Martin Michlmayr
2007-11-08 13:03 ` Woody
2007-11-10 16:52 ` Martin Michlmayr
0 siblings, 2 replies; 3+ messages in thread
From: Martin Michlmayr @ 2007-11-08 8:22 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: Woody Suwalski, Jan Rinze
Jan Rinze noticed that 16bpp screen mode is not working on Netwinder:
"After some deduction it appeared that it was running in 24bpp instead
of 16bpp. Found the bug: a missing 'break' statement at the end of a
switch case. After adding the break statement 16bpp works fine."
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
Cc: Jan Rinze <janrinze@home.nl>
Cc: Woody Suwalski <woody@suwalski.net>
--- a/drivers/video/cyber2000fb.c
+++ b/drivers/video/cyber2000fb.c
@@ -874,6 +874,8 @@ static int cyber2000fb_set_par(struct fb_info *info)
default:
BUG();
}
+ break;
+
case 24:/* TRUECOLOUR, 16m */
hw.co_pixfmt = CO_PIXFMT_24BPP;
hw.width *= 3;
--
Martin Michlmayr
http://www.cyrius.com/
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cyber2000fb.c: Fix 16bpp mode
2007-11-08 8:22 ` [PATCH] cyber2000fb.c: Fix 16bpp mode Martin Michlmayr
@ 2007-11-08 13:03 ` Woody
2007-11-10 16:52 ` Martin Michlmayr
1 sibling, 0 replies; 3+ messages in thread
From: Woody @ 2007-11-08 13:03 UTC (permalink / raw)
To: Martin Michlmayr; +Cc: linux-fbdev-devel, Jan Rinze
Martin Michlmayr wrote:
> Jan Rinze noticed that 16bpp screen mode is not working on Netwinder:
> "After some deduction it appeared that it was running in 24bpp instead
> of 16bpp. Found the bug: a missing 'break' statement at the end of a
> switch case. After adding the break statement 16bpp works fine."
>
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> Cc: Jan Rinze <janrinze@home.nl>
> Cc: Woody Suwalski <woody@suwalski.net>
>
> --- a/drivers/video/cyber2000fb.c
> +++ b/drivers/video/cyber2000fb.c
> @@ -874,6 +874,8 @@ static int cyber2000fb_set_par(struct fb_info *info)
> default:
> BUG();
> }
> + break;
> +
> case 24:/* TRUECOLOUR, 16m */
> hw.co_pixfmt = CO_PIXFMT_24BPP;
> hw.width *= 3;
>
>
Yes, with the above bug fix I have tested that 16-bit X fbdev works OK.
Woody
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cyber2000fb.c: Fix 16bpp mode
2007-11-08 8:22 ` [PATCH] cyber2000fb.c: Fix 16bpp mode Martin Michlmayr
2007-11-08 13:03 ` Woody
@ 2007-11-10 16:52 ` Martin Michlmayr
1 sibling, 0 replies; 3+ messages in thread
From: Martin Michlmayr @ 2007-11-10 16:52 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: Jan Rinze, Woody Suwalski
* Martin Michlmayr <tbm@cyrius.com> [2007-11-08 09:22]:
> Jan Rinze noticed that 16bpp screen mode is not working on Netwinder:
> "After some deduction it appeared that it was running in 24bpp instead
> of 16bpp. Found the bug: a missing 'break' statement at the end of a
> switch case. After adding the break statement 16bpp works fine."
You can ignore this patch. It went in via Russell King already, see
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c2ec21c5c8f15c079c209f403d582f3134785060
--
Martin Michlmayr
http://www.cyrius.com/
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-10 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <000501c81e5e$c1334160$4399c420$@nl>
2007-11-08 8:22 ` [PATCH] cyber2000fb.c: Fix 16bpp mode Martin Michlmayr
2007-11-08 13:03 ` Woody
2007-11-10 16:52 ` Martin Michlmayr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).