From: Sam Ravnborg <sam@ravnborg.org>
To: "Marcin Ślusarz" <marcin.slusarz@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h
Date: Thu, 13 Dec 2007 20:55:43 +0100 [thread overview]
Message-ID: <20071213195543.GA12737@uranus.ravnborg.org> (raw)
In-Reply-To: <20071213195040.GA8016@joi>
On Thu, Dec 13, 2007 at 08:50:46PM +0100, Marcin Ślusarz wrote:
> On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <marcin.slusarz@gmail.com> wrote:
> >
> > > logo: move declarations of logos to linux_logo.h
> > >
> > > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
> >
> > This patch (after I fixed it) keeps on causing trouble: mismatches between
> > the header file declarations and the actual definitions of the lookup
> > tables. This happens as I apply and unapply the patch.
> >
> > It _shouldn't_ happen, but there would appear to be some missing makefile
> > rules. I guess the C files aren't being regenerated when
> > scripts/pnmtologo.c has been altered, so the C files aren't matching the
> > header which this patch alters.
> Ok, I'll try to fix that.
The kbuild rules around the logo stuff are non-trivial.
Drop me a line (+patch) if you need help.
You may in that case also cc: linux-kbuild@vger.kernel.org.
There are some quite skilled kbuild people hanging out there too.
I may not respond promptly - busy these days (+ christmas)
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2007-12-13 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071209214027.GG9440@joi>
2007-12-13 10:31 ` [PATCH] logo: move declarations of logos to linux_logo.h Andrew Morton
2007-12-13 19:50 ` Marcin Ślusarz
2007-12-13 19:55 ` Sam Ravnborg [this message]
2007-12-13 21:31 ` Marcin Slusarz
2007-12-14 20:49 ` Geert Uytterhoeven
2007-12-14 22:00 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213195543.GA12737@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).