From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>
Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h
Date: Fri, 14 Dec 2007 23:00:05 +0100 [thread overview]
Message-ID: <20071214220005.GA22937@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712142148390.4881@anakin>
On Fri, Dec 14, 2007 at 09:49:03PM +0100, Geert Uytterhoeven wrote:
> On Thu, 13 Dec 2007, Marcin Slusarz wrote:
> > On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> > > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Åšlusarz <marcin.slusarz@gmail.com> wrote:
> > >
> > > > logo: move declarations of logos to linux_logo.h
> > > >
> > > > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > > > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
> > >
> > > This patch (after I fixed it) keeps on causing trouble: mismatches between
> > > the header file declarations and the actual definitions of the lookup
> > > tables. This happens as I apply and unapply the patch.
> > >
> > > It _shouldn't_ happen, but there would appear to be some missing makefile
> > > rules. I guess the C files aren't being regenerated when
> > > scripts/pnmtologo.c has been altered, so the C files aren't matching the
> > > header which this patch alters.
> >
> > Ok, updated patch below:
> >
> > logo: move declarations of logos to linux_logo.h
> >
> > there was a mismatch between externs in logo.c and code generated by pnmtologo
>
> This may cause section conflicts, cfr.
> http://lkml.org/lkml/2007/10/24/65
If I recall correct then if the first __initdata variable is const then
all date declared __initdata are attempted put in the const section.
So maybe a bit reordering could help it?
But that would serve a fat explanation why...
Sam
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
prev parent reply other threads:[~2007-12-14 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071209214027.GG9440@joi>
2007-12-13 10:31 ` [PATCH] logo: move declarations of logos to linux_logo.h Andrew Morton
2007-12-13 19:50 ` Marcin Ślusarz
2007-12-13 19:55 ` Sam Ravnborg
2007-12-13 21:31 ` Marcin Slusarz
2007-12-14 20:49 ` Geert Uytterhoeven
2007-12-14 22:00 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214220005.GA22937@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).