* [PATCH] tdfxfb: fix section mismatch warnings
@ 2008-01-12 1:03 Randy Dunlap
2008-01-12 4:22 ` Krzysztof Helt
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-01-12 1:03 UTC (permalink / raw)
To: linux-fbdev-devel, hmallat; +Cc: akpm, samr, adaplas
From: Randy Dunlap <randy.dunlap@oracle.com>
tdfxfb_setup() can be __devinit. This fixes the modpost section mismatch
warnings:
WARNING: vmlinux.o(.text+0x4cff9b): Section mismatch: reference to .init.data:mode_option (between 'tdfxfb_setup' and 'getclkMHz')
WARNING: vmlinux.o(.text+0x4cffa8): Section mismatch: reference to .init.data: (between 'tdfxfb_setup' and 'getclkMHz')
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/video/tdfxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.24-rc7-git1.orig/drivers/video/tdfxfb.c
+++ linux-2.6.24-rc7-git1/drivers/video/tdfxfb.c
@@ -1342,7 +1342,7 @@ out_err:
}
#ifndef MODULE
-static void tdfxfb_setup(char *options)
+static void __devinit tdfxfb_setup(char *options)
{
char *this_opt;
---
~Randy
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tdfxfb: fix section mismatch warnings
2008-01-12 1:03 [PATCH] tdfxfb: fix section mismatch warnings Randy Dunlap
@ 2008-01-12 4:22 ` Krzysztof Helt
2008-01-12 11:54 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Helt @ 2008-01-12 4:22 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: hmallat, Randy Dunlap, samr, akpm, adaplas
On Fri, 11 Jan 2008 17:03:53 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> tdfxfb_setup() can be __devinit. This fixes the modpost section mismatch
> warnings:
>
>
> #ifndef MODULE
> -static void tdfxfb_setup(char *options)
> +static void __devinit tdfxfb_setup(char *options)
> {
> char *this_opt;
It should be rather in the __init section, as it is called only
from the function below:
static int __init tdfxfb_init(void)
Regards,
Krzysztof
----------------------------------------------------------------------
Zaplanuj wyprawe na narty!
Sprawdz >>> http://link.interia.pl/f1cc8
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tdfxfb: fix section mismatch warnings
2008-01-12 4:22 ` Krzysztof Helt
@ 2008-01-12 11:54 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-01-12 11:54 UTC (permalink / raw)
To: Krzysztof Helt; +Cc: hmallat, samr, Randy Dunlap, linux-fbdev-devel, adaplas
On Sat, 12 Jan 2008 05:22:57 +0100 Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> On Fri, 11 Jan 2008 17:03:53 -0800
> Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > tdfxfb_setup() can be __devinit. This fixes the modpost section mismatch
> > warnings:
> >
> >
> > #ifndef MODULE
> > -static void tdfxfb_setup(char *options)
> > +static void __devinit tdfxfb_setup(char *options)
> > {
> > char *this_opt;
>
> It should be rather in the __init section, as it is called only
> from the function below:
>
> static int __init tdfxfb_init(void)
>
yup.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-12 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-12 1:03 [PATCH] tdfxfb: fix section mismatch warnings Randy Dunlap
2008-01-12 4:22 ` Krzysztof Helt
2008-01-12 11:54 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).