Re: [PATCH] uvesafb: fix section mismatch warnings

[Sam Ravnborg <sam@ravnborg.org>]

On Sun, Jan 13, 2008 at 10:31:34AM -0800, Randy Dunlap wrote:
> On Sat, 12 Jan 2008 11:42:03 +0100 Sam Ravnborg wrote:
> 
> > On Fri, Jan 11, 2008 at 05:04:09PM -0800, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > 
> > > Mark uvesafb_init_mtrr() as __devinit since its caller is __devinit
> > > and since it accesses __devinitdata.
> > > 
> > > WARNING: vmlinux.o(.text+0x4df80e): Section mismatch: reference to .init.data: (between 'uvesafb_init_mtrr' and 'uvesafb_show_vbe_ver')
> > 
> > OK
> > 
> > > 
> > > Variable 'blank' cannot be __devinitdata since it is referenced in an
> > > fb_ops method that could be called at any time.
> > 
> > The patch is correct but the explanation is wrong.
> > uvesafb uses local variables named blank in two spots that hides the
> > global defined blank which I assume has confused you.
> 
> Ack, thanks.

Randy - can I ask you to send an updated version with a correct changelog.
I think Andrew queued this due to my comment awaiting a conclusion.

Thanks,
	Sam

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace