From: krzysztof.h1@poczta.fm
To: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] s3c2410_fb: Fix line length calculation
Date: 18 Jan 2008 13:46:43 +0100 [thread overview]
Message-ID: <20080118124643.B8512118873@f31.poczta.interia.pl> (raw)
[-- Attachment #1: Type: TEXT/HTML, Size: 1555 bytes --]
> Fix line length calculation. var->width is the size of the display in mm. > We > like to use the pixel size. > > Without this fix, dynamic (fbset) based resolution changes with > s3c2410_fb > don\'t work at all. > > Spotted by john cass <johnpcass@yahoo.com> > > Signed-off-by: Stefan Schmidt <stefan@openmoko.org> > Signed-off-by: Harald Welte <laforge@openmoko.org> > Acked-by: Ben Dooks <ben-linux@fluff.org> > Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org> > > Index: linux-2.6/drivers/video/s3c2410fb.c > =================================================================== > --- linux-2.6.orig/drivers/video/s3c2410fb.c > +++ linux-2.6/drivers/video/s3c2410fb.c > @@ -488,7 +488,7 @@ > break; > } > > - info->fix.li
ne_length = (var->width * var->bits_per_pixel) / 8; > + info->fix.line_length = (var->xres_virtual * var->bits_per_pixel) / 8; > > /* activate this new configuration */
> > Please send this patch to Andrew Morton. Your patch also helps with depth switching. Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl> Regards, Krzysztof
<TABLE cellPadding="3" bgColor="#ffffff"><TBODY><TR><TD style="font: 12px Courier New, Courier, monotype.com; padding: 3px; background: #ffffff; color: #000000">
<BR>
----------------------------------------------------------------------
<BR>
Nadchodzi galaktyczna wojna!
<BR>
Sprawdz >> <A href="http://link.interia.pl/f1ce0">http://link.interia.pl/f1ce0</a></TD></TR></TBODY></TABLE>
[-- Attachment #2: Type: text/plain, Size: 228 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
[-- Attachment #3: Type: text/plain, Size: 182 bytes --]
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
next reply other threads:[~2008-01-18 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 12:46 krzysztof.h1 [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-14 14:40 [PATCH] s3c2410_fb: Fix line length calculation Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118124643.B8512118873@f31.poczta.interia.pl \
--to=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).