From: Andrew Morton <akpm@linux-foundation.org>
To: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Cc: marciobuss@gmail.com, bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 9564] New: Uninitialzed variable fields cvt.h_margin and cvt.v_margin
Date: Fri, 18 Jan 2008 14:00:55 -0800 [thread overview]
Message-ID: <20080118140055.fe862b78.akpm@linux-foundation.org> (raw)
In-Reply-To: <bug-9564-10286@http.bugzilla.kernel.org/>
On Fri, 14 Dec 2007 13:54:59 -0800 (PST)
bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9564
>
> Summary: Uninitialzed variable fields cvt.h_margin and
> cvt.v_margin
> Product: Drivers
> Version: 2.5
> KernelVersion: 2.6.23
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Video(Other)
> AssignedTo: drivers_video-other@kernel-bugs.osdl.org
> ReportedBy: marciobuss@gmail.com
>
>
> The errors can be found at drivers/video/fbcvt.c as follows:
>
> (1) the test "if (margin)" at line 310 evaluates to false,
> (2) this makes the test "if (cvt.flags & FB_CVT_FLAG_MARGINS)" at line 352
> to evaluate to false as well
> (3) now cvt.h_margin is uninitialized at line 359, 368, and 370, and
> cvt.v_margin is uninitizalied at line 371.
>
> In other words, both cvt.v_margin and cvt.h_margin are initialized conditinally
> but used unconditionally. This bug is a false positive only if the parameter
> "margins" at line 304 is never 0. However, this would make the test at line
> 310 unnecessary -- anyone looking at the code is miled into believing that
> 0 is a legal value for "margins". This means the code does require some change
> in my humble opinion.
>
Could someone please take a look at this?
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next parent reply other threads:[~2008-01-18 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9564-10286@http.bugzilla.kernel.org/>
2008-01-18 22:00 ` Andrew Morton [this message]
2008-01-21 17:28 ` [Bugme-new] [Bug 9564] New: Uninitialzed variable fields cvt.h_margin and cvt.v_margin Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118140055.fe862b78.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marciobuss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).