From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Subject: [RESEND][PATCH] sm501fb: clear framebuffer memory and palette Date: Mon, 21 Jan 2008 19:59:25 +0900 Message-ID: <20080121105925.12446.36815.sendpatchset@clockwork.opensource.se> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JGuQV-000594-78 for linux-fbdev-devel@lists.sourceforge.net; Mon, 21 Jan 2008 03:02:51 -0800 Received: from rv-out-0910.google.com ([209.85.198.185]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1JGuQU-0005hk-TZ for linux-fbdev-devel@lists.sourceforge.net; Mon, 21 Jan 2008 03:02:51 -0800 Received: by rv-out-0910.google.com with SMTP id g11so5849322rvb.22 for ; Mon, 21 Jan 2008 03:02:50 -0800 (PST) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: linux-fbdev-devel@lists.sourceforge.net Cc: akpm@linux-foundation.org, lethal@linux-sh.org, magnus.damm@gmail.com, ben-linux@fluff.org sm501fb: clear framebuffer memory and palette Avoid displaying garbage on unused framebuffers. For most users a single framebuffer is used together with fbcon. sm501fb supports two framebuffers where one often is assigned to fbcon and the other one is left unused during the boot. The problem here is that framebuffers not in use by fbcon happen to display garbage. This can easily be solved by making sure that framebuffer memory and palette ram are cleared. The problem can be observed by using looking at the panel output (fb1) after booting the kernel with fbcon on crt (fb0). This is the default configuration. It's also possible to watch the garbage on the crt framebuffer by passing "fbcon=map:1" on the kernel cmdline. This will assign fbcon to the panel (fb1) and leave the crt (fb0) unused. Signed-off-by: Magnus Damm --- This is the same patch that was sent to linux-fbdev-devel on 20071228. drivers/video/sm501fb.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- 0002/drivers/video/sm501fb.c +++ work/drivers/video/sm501fb.c 2007-12-27 13:24:20.000000000 +0900 @@ -1264,6 +1264,7 @@ static int sm501fb_start(struct sm501fb_ { struct resource *res; struct device *dev; + int k; int ret; info->dev = dev = &pdev->dev; @@ -1325,6 +1326,13 @@ static int sm501fb_start(struct sm501fb_ info->fbmem_len = (res->end - res->start)+1; + /* clear framebuffer memory - avoids garbage data on unused fb */ + memset(info->fbmem, 0, info->fbmem_len); + + /* clear palette ram - undefined at power on */ + for (k = 0; k < (256 * 3); k++) + writel(0, info->regs + SM501_DC_PANEL_PALETTE + (k * 4)); + /* enable display controller */ sm501_unit_power(dev->parent, SM501_GATE_DISPLAY, 1); ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/