From: Andrew Morton <akpm@linux-foundation.org>
To: tpfaff@pcs.com, adaplas@gmail.com,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] [Resend] fbcon : fix color generation for monochrome framebuffer
Date: Thu, 31 Jan 2008 14:18:56 -0800 [thread overview]
Message-ID: <20080131141856.1cdcbdfb.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080131140701.b584430e.akpm@linux-foundation.org>
On Thu, 31 Jan 2008 14:07:01 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> I'll queue the pastch up for testing as-is, but would like a de-macroed,
> de-inlined version please.
Please also pass the resulting patch through scripts/checkpatch.pl. This
version generated 23 checkpatch errors.
Also, for some reason the patch didn't apply with `patch -p1': 100%
rejects. It applied OK with patch's "-l" option. I didn't investigate why
this happened, but I guess it's your email client playing games.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-31 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 10:03 [PATCH] [Resend] fbcon : fix color generation for monochrome framebuffer Thomas Pfaff
2008-01-31 22:07 ` Andrew Morton
2008-01-31 22:18 ` Andrew Morton [this message]
2008-02-01 8:02 ` Geert Uytterhoeven
2008-02-01 11:58 ` Thomas Pfaff
2008-02-01 12:24 ` Geert Uytterhoeven
2008-02-01 13:01 ` Thomas Pfaff
2008-02-01 13:38 ` Geert Uytterhoeven
2008-02-01 13:55 ` Thomas Pfaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131141856.1cdcbdfb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=tpfaff@pcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).