Re: mode_option or mode parameter (was: i810fb module parameter 'mode_option' inconsistent with other framebuffer modules)

[Randy Dunlap <rdunlap@xenotime.net>]

On 05 Feb 2008 08:08:10 +0100 krzysztof.h1@poczta.fm wrote:

> Hi,
> 
> Few days ago, a bug was reported that the i810fb uses "mode_option" parameters while other framebuffers uses the "mode" parameter to set initial mode. It was spotted later that some drivers uses "mode_option", some uses "mode" and some does use none.
> 
> I want to ask what is a correct way. I can rework at least some of the drivers to a standard way, but I don't know what the standard is.

Hi,
Hopefully one of the fbdev driver developers will know for sure.

I would (do) say that "mode_option" is being redundant.  Yes, it's
an option, but we don't usually name options (in other parts of the
kernel) with an _option suffix.  Sure, the variable could be called
<mode_option>, but the userspace name should just be "mode".  IMHO.

Please keep Documentation/fb/modedb.txt updated if you make any
relevant changes.

Thanks.
---
~Randy

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/