From: Andrew Morton <akpm@linux-foundation.org>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: eric miao <eric.y.miao@gmail.com>,
linux-kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH 1/8] pxa: un-nest pxafb_parse_options() to cleanup the coding style issue
Date: Wed, 5 Mar 2008 23:13:08 -0800 [thread overview]
Message-ID: <20080305231308.04965017.akpm@linux-foundation.org> (raw)
In-Reply-To: <f17812d70802261833v7d6dbff3jd9b436ee6dfda4a0@mail.gmail.com>
On Wed, 27 Feb 2008 10:33:10 +0800 "eric miao" <eric.y.miao@gmail.com> wrote:
> >From e946f577d3f869abcc587629e2fdd5f1563ce1df Mon Sep 17 00:00:00 2001
> From: eric miao <eric.miao@marvell.com>
> Date: Fri, 22 Feb 2008 11:29:08 +0800
> Subject: [PATCH] pxa: un-nest pxafb_parse_options() to cleanup the
> coding style issue
>
> pxafb_parse_options() has very long lines exceeding far beyond 80
> characters, which makes the function looks bad. Un-nest it into
> smaller functions and use a temporary string for only what has been
> overridden instead of the whole dev_info() message to reduce the
> line a bit more.
>
These patches were all badly wordwrapped. Please refresh them against the
latest mainline kernel, fix your email client and then resend them, being
sure to cc myself.
Thanks.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-03-06 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 2:33 [PATCH 1/8] pxa: un-nest pxafb_parse_options() to cleanup the coding style issue eric miao
2008-03-06 7:13 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305231308.04965017.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).