From: Michal Januszewski <spock@gentoo.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors
Date: Sun, 16 Mar 2008 12:23:38 +0100 [thread overview]
Message-ID: <20080316112338.GA4788@spock.one.pl> (raw)
In-Reply-To: <20080305225412.ad1d3bb5.akpm@linux-foundation.org>
From: Michal Januszewski <spock@gentoo.org>
Don't treat valid modes returned by fb_find_mode() (best-fit modes,
default modes or the first valid mode) as errors.
Currently, when fb_find_mode() finds a valid mode belonging to one
of the above-mentioned classes, uvesafb will ignore it and will try
to set a 640x480 video mode. The expected behaviour (introduced by
this patch) would be to use the valid mode returned by fb_find_mode()
instead.
Signed-off-by: Michal Januszewski <spock@gentoo.org>
---
As requested, this patch contains an expanded changelog message. The
bug is by no means critical and should have no impact on the large
majority of users, so it's definitely not 2.6.24 material.
diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
index a14ef89..fc68b3e 100644
--- a/drivers/video/uvesafb.c
+++ b/drivers/video/uvesafb.c
@@ -885,7 +885,7 @@ static int __devinit uvesafb_vbe_init_mode(struct fb_info *info)
}
/* fb_find_mode() failed */
- if (i == 0 || i >= 3) {
+ if (i == 0) {
info->var.xres = 640;
info->var.yres = 480;
mode = (struct fb_videomode *)
prev parent reply other threads:[~2008-03-16 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 11:34 [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors Michal Januszewski
2008-03-06 6:54 ` Andrew Morton
2008-03-16 11:23 ` Michal Januszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080316112338.GA4788@spock.one.pl \
--to=spock@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).