* [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors
@ 2008-01-27 11:34 Michal Januszewski
2008-03-06 6:54 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Michal Januszewski @ 2008-01-27 11:34 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: linux-kernel
From: Michal Januszewski <spock@gentoo.org>
Don't treat valid modes returned by fb_find_mode() (best-fit modes,
default modes or the first valid mode) as errors.
Signed-off-by: Michal Januszewski <spock@gentoo.org>
---
diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
index a14ef89..fc68b3e 100644
--- a/drivers/video/uvesafb.c
+++ b/drivers/video/uvesafb.c
@@ -885,7 +885,7 @@ static int __devinit uvesafb_vbe_init_mode(struct fb_info *info)
}
/* fb_find_mode() failed */
- if (i == 0 || i >= 3) {
+ if (i == 0) {
info->var.xres = 640;
info->var.yres = 480;
mode = (struct fb_videomode *)
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors
2008-01-27 11:34 [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors Michal Januszewski
@ 2008-03-06 6:54 ` Andrew Morton
2008-03-16 11:23 ` Michal Januszewski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-03-06 6:54 UTC (permalink / raw)
Cc: Michal Januszewski, linux-fbdev-devel, linux-kernel
On Sun, 27 Jan 2008 12:34:56 +0100 Michal Januszewski <spock@gentoo.org> wrote:
> From: Michal Januszewski <spock@gentoo.org>
>
> Don't treat valid modes returned by fb_find_mode() (best-fit modes,
> default modes or the first valid mode) as errors.
>
This changelog is too brief.
> ---
> diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
> index a14ef89..fc68b3e 100644
> --- a/drivers/video/uvesafb.c
> +++ b/drivers/video/uvesafb.c
> @@ -885,7 +885,7 @@ static int __devinit uvesafb_vbe_init_mode(struct fb_info *info)
> }
>
> /* fb_find_mode() failed */
> - if (i == 0 || i >= 3) {
> + if (i == 0) {
> info->var.xres = 640;
> info->var.yres = 480;
> mode = (struct fb_videomode *)
>
Because I cannot tell what are the consequences of the bug which you're
fixing, hence I cannot tell whether we need this fix in 2.6.25 or even
2.6.24.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors
2008-03-06 6:54 ` Andrew Morton
@ 2008-03-16 11:23 ` Michal Januszewski
0 siblings, 0 replies; 3+ messages in thread
From: Michal Januszewski @ 2008-03-16 11:23 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-fbdev-devel, linux-kernel
From: Michal Januszewski <spock@gentoo.org>
Don't treat valid modes returned by fb_find_mode() (best-fit modes,
default modes or the first valid mode) as errors.
Currently, when fb_find_mode() finds a valid mode belonging to one
of the above-mentioned classes, uvesafb will ignore it and will try
to set a 640x480 video mode. The expected behaviour (introduced by
this patch) would be to use the valid mode returned by fb_find_mode()
instead.
Signed-off-by: Michal Januszewski <spock@gentoo.org>
---
As requested, this patch contains an expanded changelog message. The
bug is by no means critical and should have no impact on the large
majority of users, so it's definitely not 2.6.24 material.
diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
index a14ef89..fc68b3e 100644
--- a/drivers/video/uvesafb.c
+++ b/drivers/video/uvesafb.c
@@ -885,7 +885,7 @@ static int __devinit uvesafb_vbe_init_mode(struct fb_info *info)
}
/* fb_find_mode() failed */
- if (i == 0 || i >= 3) {
+ if (i == 0) {
info->var.xres = 640;
info->var.yres = 480;
mode = (struct fb_videomode *)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-16 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-27 11:34 [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors Michal Januszewski
2008-03-06 6:54 ` Andrew Morton
2008-03-16 11:23 ` Michal Januszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).