From: Pavel Machek <pavel@ucw.cz>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
linux-kernel@vger.kernel.org, info-linux@geode.amd.com,
jordan.crouse@amd.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/7] lxfb: add power management functionality
Date: Mon, 31 Mar 2008 09:40:03 +0200 [thread overview]
Message-ID: <20080331074002.GB5106@ucw.cz> (raw)
In-Reply-To: <20080327201050.34a8ffdd@ephemeral>
Hi!
> +static int lxfb_suspend(struct pci_dev *pdev, pm_message_t state)
> +{
> + struct fb_info *info = pci_get_drvdata(pdev);
> +
> + if (pdev->dev.power.power_state.event == state.event)
> + return 0;
This should never trigger. See Doc*/feature-removal-sch*.
> + /* there's no point in setting PCI states; we emulate PCI, so
> + * we don't end up getting power savings anyways */
> +
> + pdev->dev.power.power_state = state;
And there's no point doing this.
> + pdev->dev.power.power_state = PMSG_ON;
Or this.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
prev parent reply other threads:[~2008-03-31 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 0:10 [PATCH 5/7] lxfb: add power management functionality Andres Salomon
2008-03-31 7:40 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331074002.GB5106@ucw.cz \
--to=pavel@ucw.cz \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=info-linux@geode.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).