Re: [PATCH 1/2 2.6.24] fbdev: platforming metronomefb and am200epd

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 03 Apr 2008 01:19:08 -0400
Jaya Kumar <jayakumar.lkml@gmail.com> wrote:

> Hi Tony, Geert, Andrew, fbdev,
> 
> This patchset has 2 patches. They are are in order to split metronomefb and
> hecubafb into platform independent (platform drivers) and platform specific
> (platform devices) drivers which are am200epd (arm) and n411 (x86). The
> improvement over the last time I posted this is that I've now added module
> refcount handling in the platform drivers and so module loading/unloading
> works.
> 
> I would be grateful for any feedback on this.
> 
> Thanks,
> jaya
> 
> This patch splits metronomefb into the platform independent metronomefb and
> the platform dependent am200epd. It also includes some comment cleanup and
> a bugfix for the use of cfb_* functions instead of sys_* functions. The 
> Kconfig and Makefile changes include the changes needed for hecubafb and
> n411.
> 

argh.

Please don't mix huge code-motion changes into the same patch with bugfixes!

a) we want to be able to look at and review that bugfix in isolation

b) what happens if someone (eg a distro) is shipping 2.6.23 and wants to
backport your bugfix?


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace