Re: OLPC: gxfb/lxfb: add DCON panel modes to framebuffer drivers

[Andres Salomon <dilinger@queued.net>]

On Mon, 14 Apr 2008 09:18:56 -0600
Jordan Crouse <jordan.crouse@amd.com> wrote:

> On 14/04/08 10:33 +0200, Arnd Bergmann wrote:
> > On Monday 14 April 2008, Andres Salomon wrote:
> > > Since there's no way to autodetect panel modes, we're forced to hardcode
> > > them in the driver and add a big fat #ifdef.  The OLPC DCON needs a
> > > specific mode line (at 1200x900).  This adds it to both gxfb and lxfb.
> > > 
> > > Signed-off-by: Andres Salomon <dilinger@debian.org>
> > 
> > Since the XO is based on Open Firmware, shouldn't the panel size really be
> > a property in the device tree that can be read by this driver?
> 
> Andre's description was slightly misleading.  We could probably detect
> the panel mode, but there isn't any reason to since the panel timings
> are well known and won't change.  While OFW detection would be good
> computer science fu, it would be a wasted effort since its so easy to hard
> code them into the table.
> 
> Jordan
> 

Right, that's what I get for sending this stuff out at 4am.  To be clear,
the issue that we have to hard code ways to access panel timing info on a
per-platform and/or per-bios basis.  There's no standard way to fetch
it across all Geodes (that I'm aware of).  Even the VSA doesn't really
help us here.



-- 
Need a kernel or Debian developer?  Contact me, I'm looking for contracts.