From: Jordan Crouse <jordan.crouse@amd.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andres Salomon <dilinger@queued.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, info-linux@geode.amd.com,
adaplas@gmail.com, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: OLPC: gxfb/lxfb: add DCON panel modes to framebuffer drivers
Date: Mon, 14 Apr 2008 09:18:56 -0600 [thread overview]
Message-ID: <20080414151856.GA10111@cosmic.amd.com> (raw)
In-Reply-To: <200804141033.59998.arnd@arndb.de>
On 14/04/08 10:33 +0200, Arnd Bergmann wrote:
> On Monday 14 April 2008, Andres Salomon wrote:
> > Since there's no way to autodetect panel modes, we're forced to hardcode
> > them in the driver and add a big fat #ifdef. The OLPC DCON needs a
> > specific mode line (at 1200x900). This adds it to both gxfb and lxfb.
> >
> > Signed-off-by: Andres Salomon <dilinger@debian.org>
>
> Since the XO is based on Open Firmware, shouldn't the panel size really be
> a property in the device tree that can be read by this driver?
Andre's description was slightly misleading. We could probably detect
the panel mode, but there isn't any reason to since the panel timings
are well known and won't change. While OFW detection would be good
computer science fu, it would be a wasted effort since its so easy to hard
code them into the table.
Jordan
--
Jordan Crouse
Systems Software Development Engineer
Advanced Micro Devices, Inc.
next prev parent reply other threads:[~2008-04-14 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 7:53 [PATCH 3/3] OLPC: gxfb/lxfb: add DCON panel modes to framebuffer drivers Andres Salomon
2008-04-14 8:33 ` Arnd Bergmann
2008-04-14 15:18 ` Jordan Crouse [this message]
2008-04-14 15:33 ` Andres Salomon
2008-04-15 1:21 ` [PATCH 3/3] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414151856.GA10111@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dilinger@queued.net \
--cc=info-linux@geode.amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).