linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: eric miao <eric.y.miao@gmail.com>
Cc: linux@arm.linux.org.uk, linux-fbdev-devel@lists.sourceforge.net,
	linux-arm-kernel@lists.arm.linux.org.uk, daniel@caiaq.de
Subject: Re: [PATCH RFC] pxafb: introduce "struct pxafb_output" to abstract the output interface
Date: Tue, 15 Apr 2008 17:22:46 -0700	[thread overview]
Message-ID: <20080415172246.292760a5.akpm@linux-foundation.org> (raw)
In-Reply-To: <f17812d70804080259n7e69fc54n7a18bca77c88b8bb@mail.gmail.com>

> Subject: [PATCH RFC] pxafb: introduce "struct pxafb_output" to abstract the output interface

I'm not really sure who we can request comments from on this one.

The code looks OK to me from a quick scan - but you're largely on your own on
this one.

On Tue, 8 Apr 2008 17:59:14 +0800
"eric miao" <eric.y.miao@gmail.com> wrote:

> Currently two output interfaces are supported:
> 
>     ppi - parallel port interface
>     spi - smart panel interface
> 
> and possibly MIPI or video output in the future.

I get a monster reject when applying this on the current patchset.  Perhaps
because there are also changes to drivers/video/pxafb.c in git-arm.patch.

It would be best please if you could redo the patch against
http://userweb.kernel.org/~akpm/mmotm/.  I've also uploaded a single rolled
up patch against 2.6.25-rc9 at http://userweb.kernel.org/~akpm/em.gz.

Please try to lessen the wordwrapping in the next version, thanks ;)

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

      reply	other threads:[~2008-04-16  0:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08  9:59 [PATCH RFC] pxafb: introduce "struct pxafb_output" to abstract the output interface eric miao
2008-04-16  0:22 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080415172246.292760a5.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=daniel@caiaq.de \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).