Re: [PATCH] [FB] Add the carmine FB driver.

[Sebastian Siewior <frame+buffer@ml.breakpoint.cc>]

* Jaya Kumar | 2008-04-20 08:03:18 [-0400]:

>On Fri, Apr 18, 2008 at 1:28 PM, Sebastian Siewior
><frame+buffer@ml.breakpoint.cc> wrote:
>>  +#ifndef MODULE
>>  +static int __init carminefb_setup(void)
>>  +{
>>  +       char *options;
>>  +
>>  +       if (fb_get_options("carmine", &options))
>>  +               return -ENXIO;
>
>Hi Sebastian,
Hi Jaya,

>Interesting work. btw, I think there was some discussion of
>deprecating the fb_get_options and associated manual parsing code in
>favor of using module.option = value. Since this is a new driver, is
>there an advantage in keeping the legacy option support?
I grabed a random driver as a template and the driver was using that
interface. I could get rid of this parsing code and use module options
only if this is prefered these days.
On a second look this is probably the better solution since I don't have
to care about to option interfaces.

>>  +
>>  +               if (!strncmp(this_opt, "mode:", 5))
>>  +                       carminefb_mode = simple_strtoul(this_opt + 5, NULL, 0);
>
>checkpatch suggests using strict_strtoul.
Indeed. I didn't notice this before. I get rid of this.

>Thanks,
>jaya
Thanks for review.

Sebastian

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone