Re: [PATCH] tridentfb: replace macros with functions

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 02 May 2008 11:22:45 +0200 "Krzysztof Helt" <krzysztof.h1@wp.pl> wrote:

> This patch replaces macros with static functions and
> puts tridentfb_par pointer as the first argument of
> these functions. These is a step toward multihead
> support.
> 
> Additionally, bogus TRIDENT_MMIO define is removed as
> the driver supports graphics cards only through the mmio mode.

Something went wrong here..

drivers/video/tridentfb.c: In function 'tridentfb_fillrect':
drivers/video/tridentfb.c:518: warning: passing argument 1 of 'acc->fill_rect' makes pointer from integer without a cast
drivers/video/tridentfb.c:518: error: too few arguments to function 'acc->fill_rect'
drivers/video/tridentfb.c:519: error: too few arguments to function 'acc->wait_engine'
drivers/video/tridentfb.c: In function 'tridentfb_copyarea':
drivers/video/tridentfb.c:524: warning: passing argument 1 of 'acc->copy_rect' makes pointer from integer without a cast
drivers/video/tridentfb.c:524: error: too few arguments to function 'acc->copy_rect'
drivers/video/tridentfb.c:525: error: too few arguments to function 'acc->wait_engine'
drivers/video/tridentfb.c: In function 'tridentfb_set_par':
drivers/video/tridentfb.c:1018: warning: passing argument 1 of 'acc->init_accel' makes pointer from integer without a cast
drivers/video/tridentfb.c:1018: error: too few arguments to function 'acc->init_accel'


Also, checkpatch says

ERROR: "(foo*)" should be "(foo *)"
#863: FILE: drivers/video/tridentfb.c:1123:
+       struct tridentfb_par *par = (struct tridentfb_par*)info->par;

ERROR: "(foo*)" should be "(foo *)"
#887: FILE: drivers/video/tridentfb.c:1160:
+       struct tridentfb_par *par = (struct tridentfb_par*)info->par;

which is easily fixed by just removing the unneeded typecasts of void*.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone