From: Andrew Morton <akpm@linux-foundation.org>
To: Sebastian Siewior <frame+buffer@ml.breakpoint.cc>
Cc: tglx@linutronix.de, linux-fbdev-devel@lists.sourceforge.net,
adaplas@gmail.com
Subject: Re: [PATCH V7] [FB] Add the carmine FB driver.
Date: Fri, 2 May 2008 16:21:14 -0700 [thread overview]
Message-ID: <20080502162114.b6a5e617.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080502172754.GA18973@Chamillionaire.breakpoint.cc>
On Fri, 2 May 2008 19:27:54 +0200
Sebastian Siewior <frame+buffer@ml.breakpoint.cc> wrote:
> +static const struct fb_videomode carmine_modedb[] = {
> + {
> + .name = "640x480",
> + .xres = 640,
> + .yres = 480,
> + .pixclock = 0,
> + .left_margin = 0,
> + .right_margin = 0,
> + .upper_margin = 0,
> + .lower_margin = 0,
> + .hsync_len = 0,
> + .vsync_len = 0,
> + .sync = 0,
> + .vmode = 0,
> + .flag = 0,
> + }, {
> + .name = "800x600",
> + .xres = 800,
> + .yres = 600,
> + .pixclock = 0,
> + },
> +};
The initialisations with zero here aren't needed - the compiler does it.
Normally we omit them, but sometimes they can be nice for commentary
reasons. A minor thing.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-05-02 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 17:27 [PATCH V7] [FB] Add the carmine FB driver Sebastian Siewior
2008-05-02 23:21 ` Andrew Morton [this message]
2008-05-03 6:01 ` Sebastian Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502162114.b6a5e617.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=frame+buffer@ml.breakpoint.cc \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).