From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH V7] [FB] Add the carmine FB driver. Date: Fri, 2 May 2008 16:21:14 -0700 Message-ID: <20080502162114.b6a5e617.akpm@linux-foundation.org> References: <20080502172754.GA18973@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1Js4ZG-0006Qd-O8 for linux-fbdev-devel@lists.sourceforge.net; Fri, 02 May 2008 16:21:30 -0700 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Js4ZF-0008Cp-BA for linux-fbdev-devel@lists.sourceforge.net; Fri, 02 May 2008 16:21:30 -0700 In-Reply-To: <20080502172754.GA18973@Chamillionaire.breakpoint.cc> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Sebastian Siewior Cc: tglx@linutronix.de, linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com On Fri, 2 May 2008 19:27:54 +0200 Sebastian Siewior wrote: > +static const struct fb_videomode carmine_modedb[] = { > + { > + .name = "640x480", > + .xres = 640, > + .yres = 480, > + .pixclock = 0, > + .left_margin = 0, > + .right_margin = 0, > + .upper_margin = 0, > + .lower_margin = 0, > + .hsync_len = 0, > + .vsync_len = 0, > + .sync = 0, > + .vmode = 0, > + .flag = 0, > + }, { > + .name = "800x600", > + .xres = 800, > + .yres = 600, > + .pixclock = 0, > + }, > +}; The initialisations with zero here aren't needed - the compiler does it. Normally we omit them, but sometimes they can be nice for commentary reasons. A minor thing. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone