Re: [PATCH] tridentfb: acceleration code improvements

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 14 May 2008 07:12:00 +0200
Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:

> This patch brings various acceleration improvements:
> - set  copyarea/fillrect for non-accelerated framebuffer (fix)
> - remove 15 bpp depth handling to simplify code as it hardly 
>   works (15 bpp handling was obviously missing in some switches)
> - add fb_sync call and move waiting before accelerated function
>   to make acceleration more asynchronous to cpu (few % of speed
>   improvement)
> - add cpu_relax() call in waiting loops
> - make longer register names and name more registers
> - move registers' definition to header
> - general code improvements (shortening, simplifying)

checkpatch whines:

ERROR: space required after that ',' (ctx:VxV)
#543: FILE: include/video/trident.h:7:
+#define debug(f,a...)  printk("%s:" f,  __FUNCTION__ , ## a);mdelay(100);
                ^

ERROR: space required after that ';' (ctx:VxV)
#543: FILE: include/video/trident.h:7:
+#define debug(f,a...)  printk("%s:" f,  __FUNCTION__ , ## a);mdelay(100);
                                                             ^

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#543: FILE: include/video/trident.h:7:
+#define debug(f,a...)  printk("%s:" f,  __FUNCTION__ , ## a);mdelay(100);

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#543: FILE: include/video/trident.h:7:
+#define debug(f,a...)  printk("%s:" f,  __FUNCTION__ , ## a);mdelay(100);


perhaps that's all in your todo somewhere.


Also that macro is plain wrong:

	if (foo)
		debug(...);
	else
		something();

won't compile.  Using the do{...}while(0) thing or perhaps {(...)} will fix.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/