From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] tridentfb: acceleration code improvements
Date: Thu, 15 May 2008 22:16:15 -0700 [thread overview]
Message-ID: <20080515221615.b6791dee.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080516064602.f4313fef.krzysztof.h1@poczta.fm>
On Fri, 16 May 2008 06:46:02 +0200 Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> On Thu, 15 May 2008 15:56:14 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Wed, 14 May 2008 07:12:00 +0200
> > checkpatch whines:
> >
> > ERROR: space required after that ',' (ctx:VxV)
> (...)
>
> How do you run the checkpatch? I am not getting these warning even with the "--strict" option (stock linux-2.6.26-rc2 kernel scripts). Do you have another version?
> I'd like to have the same version as you.
doh. -mm's update-checkpatchpl-to-version-019.patch is needed to pick
up this problem.
> >
> > Also that macro is plain wrong:
> >
> > if (foo)
> > debug(...);
> > else
> > something();
> >
> > won't compile. Using the do{...}while(0) thing or perhaps {(...)} will fix.
> >
> I'll fix it.
Cool.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-05-16 5:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 5:12 [PATCH] tridentfb: acceleration code improvements Krzysztof Helt
2008-05-15 22:56 ` Andrew Morton
2008-05-16 4:46 ` Krzysztof Helt
2008-05-16 5:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515221615.b6791dee.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).