From: Ben Dooks <ben-fbdev@fluff.org>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: akpm@linux-foundation.org, Ben Dooks <ben-linux@fluff.org>,
arnaud.patard@rtp-net.org
Subject: [patch 3/5] S3C2410: Add error print if we cannot add attribute
Date: Tue, 20 May 2008 13:49:57 +0100 [thread overview]
Message-ID: <20080520125030.375895346@fluff.org.uk> (raw)
In-Reply-To: 20080520124954.001898813@fluff.org.uk
[-- Attachment #1: simtec/simtec-drivers-fb-s3c2410-warningfix.patch --]
[-- Type: text/plain, Size: 1329 bytes --]
Fix the following warning by checking the result of
device_create_file and printing an error but not removing
the device (loss of debug registers is not fatal).
drivers/video/s3c2410fb.c:905: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.26-rc3-quilt1/drivers/video/s3c2410fb.c
===================================================================
--- linux-2.6.26-rc3-quilt1.orig/drivers/video/s3c2410fb.c 2008-05-19 23:38:20.000000000 +0100
+++ linux-2.6.26-rc3-quilt1/drivers/video/s3c2410fb.c 2008-05-19 23:40:51.000000000 +0100
@@ -972,7 +972,10 @@ static int __init s3c24xxfb_probe(struct
}
/* create device files */
- device_create_file(&pdev->dev, &dev_attr_debug);
+ ret = device_create_file(&pdev->dev, &dev_attr_debug);
+ if (ret) {
+ printk(KERN_ERR "failed to add debug attribute\n");
+ }
printk(KERN_INFO "fb%d: %s frame buffer device\n",
fbinfo->node, fbinfo->fix.id);
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-05-20 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 12:49 [patch 0/5] FB fixes for 2.6.26-rc series Ben Dooks
2008-05-20 12:49 ` [patch 1/5] SM501: Reverse FPEN/VBIASEN flags behaviour Ben Dooks
2008-05-20 12:49 ` [patch 2/5] S3C2410: Ensure that FB_BLANK_POWERDOWN shuts down the controller Ben Dooks
2008-05-20 12:49 ` Ben Dooks [this message]
2008-05-20 12:49 ` [patch 4/5] S3C2410: Clean out changelog header and tidy Ben Dooks
2008-05-20 12:49 ` [patch 5/5] S3C2410: Fix driver MODULE_ALIAS() Ben Dooks
2008-05-20 20:59 ` [patch 0/5] FB fixes for 2.6.26-rc series Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520125030.375895346@fluff.org.uk \
--to=ben-fbdev@fluff.org \
--cc=akpm@linux-foundation.org \
--cc=arnaud.patard@rtp-net.org \
--cc=ben-linux@fluff.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).