From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] modedb: fix incorrect sync and vmode flags for CVT modes
Date: Wed, 28 May 2008 13:56:20 -0700 [thread overview]
Message-ID: <20080528135620.5a1ba19d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080528224921.da1f0f15.krzysztof.h1@poczta.fm>
On Wed, 28 May 2008 22:49:21 +0200
Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> Testing of the tridentfb seems like a good exercise
> for the fbdev layer.
heh.
> + memset(&cvt_mode, 0, sizeof(struct fb_videomode));
I think using sizeof(cvt_mode) is better here. Then the reader doesn't
have to go and hunt down the definition of cvt_mode.
Or even
--- a/drivers/video/modedb.c~a
+++ a/drivers/video/modedb.c
@@ -582,7 +582,7 @@ int fb_find_mode(struct fb_var_screeninf
}
done:
if (cvt) {
- struct fb_videomode cvt_mode;
+ struct fb_videomode cvt_mode = { };
int ret;
DPRINTK("CVT mode %dx%d@%dHz%s%s%s\n", xres, yres,
_
however gcc might generate sucky code for that.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-05-28 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 20:49 [PATCH] modedb: fix incorrect sync and vmode flags for CVT modes Krzysztof Helt
2008-05-28 20:56 ` Andrew Morton [this message]
2008-05-28 21:48 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528135620.5a1ba19d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).