Re: [PATCH resend] Adding dummy release functions to avoid warnings.

Re: [PATCH resend] Adding dummy release functions to avoid warnings.

[Andrew Morton]

On Thu, 5 Jun 2008 12:39:46 +0300 "Vitaliy Ivanov" <vitalivanov@gmail.com> wrote:

> Hi all,
> 
> Natalie reported that patch wasn't accepted.
> Please check this out. If I need to correct it somehow then pls let me know.
> 
> V.
> 
> ---------- Forwarded message ----------
> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> Date: Wed, Apr 16, 2008 at 3:34 AM
> Subject: [PATCH] Adding dummy release functions to avoid warnings.
> To: linux-kernel@vger.kernel.org, devzero@web.de, jsun@junsun.net,
> dwmw2@infradead.org
> 
> 
> 
> Subject: [PATCH] Adding dummy release functions to avoid warnings.
> 
> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> 
> Trivial fix for #9690.
> Added simple release functions that doing nothing.
> Not sure whether we can leave it as is or to rework using
> platform_device helpers like platform_device_alloc.

Please see Documentation/kobject.txt - search for the text
"mocked mercilessly" :)

> This approach is used in many drivers.
> --
> 
>  drivers/mtd/maps/physmap.c |    6 ++++++

Let's mock David too!

>  drivers/video/hgafb.c      |   10 +++++++++-

I expect that
hgafb-convert-to-new-platform-driver-api-bugzilla-9689.patch which I
merged yesterday will help here.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

Re: [PATCH resend] Adding dummy release functions to avoid warnings.

[David Woodhouse]

On Thu, 2008-06-05 at 09:07 -0700, Andrew Morton wrote:

> Please see Documentation/kobject.txt - search for the text
> "mocked mercilessly" :)

> > 
> >  drivers/mtd/maps/physmap.c |    6 ++++++
> 
> Let's mock David too!

Do not taunt Happy Fun Dave.

-- 
dwmw2

Re: [PATCH resend] Adding dummy release functions to avoid warnings.

[Vitaliy Ivanov]

Andrew,

On Thu, 2008-06-05 at 19:07, Andrew Morton wrote:
> On Thu, 5 Jun 2008 12:39:46 +0300 "Vitaliy Ivanov" <vitalivanov@gmail.com> wrote:
> > Trivial fix for #9690.
> > Added simple release functions that doing nothing.
> > Not sure whether we can leave it as is or to rework using
> > platform_device helpers like platform_device_alloc.
> 
> Please see Documentation/kobject.txt - search for the text
> "mocked mercilessly" :)
> 
> > This approach is used in many drivers.
> > --
> > 
> >  drivers/mtd/maps/physmap.c |    6 ++++++
> 
> Let's mock David too!

Damn. I knew that everything is not so easy here;) Got it. Tnx.

But in such case there are _again_ many drivers that do implement such
fake functions. Again is because when I tried to port some usb driver
there were issues with locking that was not correct but many drivers
worked exactly this incorrect way.

Anyway, tnx for clarifying this.

V.