From: Grant Grundler <grundler@parisc-linux.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Jon Smirl <jonsmirl@yahoo.com>,
Linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org
Subject: Re: [RESEND] [PATCH] convert sticore.c to PCI ROM API
Date: Sat, 7 Jun 2008 14:34:28 -0600 [thread overview]
Message-ID: <20080607203428.GA23115@colo.lackof.org> (raw)
In-Reply-To: <20080607110836.b2c9f48a.krzysztof.h1@poczta.fm>
On Sat, Jun 07, 2008 at 11:08:36AM +0200, Krzysztof Helt wrote:
...
> I am forwarding it to the reporter of the bug 9425 as this bug should be
> closed without changing the code.
Actually, we should change the code: add a comment that summarizes jejb's
feedback (and the rest of the conversation) so we don't repeat this
exercise again in 2 years.
thanks,
grant
>
> A very similar case is for the bug 9424. I analyzed code for the Matrox
> framebuffers and it is not worth changing. The idea behind the pci_map_rom()
> is that it enables and maps the ROM area. The Matrox framebuffer has
> these two separated as the ROM may appear in the already mapped area.
> The ROM is always enabled but not always mapped.
>
> The only unification I see is to export pci_rom_enable/pci_rom_disable()
> and use them inside the Matrox and sticore drivers (so no ioremap()
> is done but the code is shorter).
>
> Regards,
> Krzysztof
>
> ----------------------------------------------------------------------
> Tanie rozmowy!
> Sprawdz >>> http://link.interia.pl/f1e22
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-07 20:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 21:13 [RESEND] [PATCH] convert sticore.c to PCI ROM API Krzysztof Helt
2008-06-05 22:11 ` Andrew Morton
2008-06-06 18:52 ` Krzysztof Helt
2008-06-05 22:26 ` James Bottomley
2008-06-06 20:35 ` Krzysztof Helt
2008-06-06 23:27 ` James Bottomley
2008-06-07 9:08 ` Krzysztof Helt
2008-06-07 20:34 ` Grant Grundler [this message]
2008-06-06 21:23 ` Helge Deller
-- strict thread matches above, loose matches on Subject: below --
2008-06-07 20:51 Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080607203428.GA23115@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=jonsmirl@yahoo.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).