Re: [PATCH] radeonfb: Give i2c buses nicer names

[Jean Delvare <khali@linux-fr.org>]

On Fri, 06 Jun 2008 19:21:37 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2008-06-06 at 11:19 +0200, Jean Delvare wrote:
> > The name of the i2c buses shows in the output of "i2cdetect -l", so
> > it's important to give informative names.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> 
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Hmm, does this mean that you won't take care of pushing the patch
upstream? Driver maintainers usually do that...

> > ---
> >  drivers/video/aty/radeon_i2c.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > --- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c	2008-06-03 09:57:31.000000000 +0200
> > +++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c	2008-06-06 08:43:51.000000000 +0200
> > @@ -69,7 +69,8 @@ static int radeon_setup_i2c_bus(struct r
> >  {
> >  	int rc;
> >  
> > -	strcpy(chan->adapter.name, name);
> > +	snprintf(chan->adapter.name, sizeof(chan->adapter.name),
> > +		 "radeonfb %s", name);
> >  	chan->adapter.owner		= THIS_MODULE;
> >  	chan->adapter.id		= I2C_HW_B_RADEON;
> >  	chan->adapter.algo_data		= &chan->algo;
> > 

-- 
Jean Delvare

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php