From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] radeonfb: Give i2c buses nicer names Date: Sun, 8 Jun 2008 15:50:56 +0200 Message-ID: <20080608155056.4506f457@hyperion.delvare> References: <20080606111955.5583e81a@hyperion.delvare> <1212744097.12464.29.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1K5LIo-0005nb-19 for linux-fbdev-devel@lists.sourceforge.net; Sun, 08 Jun 2008 06:51:22 -0700 Received: from zone0.gcu-squad.org ([212.85.147.21] helo=services.gcu-squad.org) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1K5LIl-000220-KO for linux-fbdev-devel@lists.sourceforge.net; Sun, 08 Jun 2008 06:51:22 -0700 In-Reply-To: <1212744097.12464.29.camel@pasglop> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: benh@kernel.crashing.org Cc: linux-fbdev-devel@lists.sourceforge.net On Fri, 06 Jun 2008 19:21:37 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2008-06-06 at 11:19 +0200, Jean Delvare wrote: > > The name of the i2c buses shows in the output of "i2cdetect -l", so > > it's important to give informative names. > > > > Signed-off-by: Jean Delvare > > Acked-by: Benjamin Herrenschmidt Hmm, does this mean that you won't take care of pushing the patch upstream? Driver maintainers usually do that... > > --- > > drivers/video/aty/radeon_i2c.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c 2008-06-03 09:57:31.000000000 +0200 > > +++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c 2008-06-06 08:43:51.000000000 +0200 > > @@ -69,7 +69,8 @@ static int radeon_setup_i2c_bus(struct r > > { > > int rc; > > > > - strcpy(chan->adapter.name, name); > > + snprintf(chan->adapter.name, sizeof(chan->adapter.name), > > + "radeonfb %s", name); > > chan->adapter.owner = THIS_MODULE; > > chan->adapter.id = I2C_HW_B_RADEON; > > chan->adapter.algo_data = &chan->algo; > > -- Jean Delvare ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php