From: Jean Delvare <khali@linux-fr.org>
To: Antonino Daplas <adaplas@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] radeonfb: Revert "Fix radeon DDC regression"
Date: Tue, 17 Jun 2008 14:50:40 +0200 [thread overview]
Message-ID: <20080617145040.55c5c088@hyperion.delvare> (raw)
The bug was in fb_ddc and was fixed by commit
b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk)
so the workaround in radeonfb can be removed now.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
Antonino, can you please push this upstream? Thanks.
drivers/video/aty/radeon_i2c.c | 4 ----
1 file changed, 4 deletions(-)
--- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c 2008-06-06 08:43:51.000000000 +0200
+++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c 2008-06-06 09:28:50.000000000 +0200
@@ -139,12 +139,8 @@ void radeon_delete_i2c_busses(struct rad
int radeon_probe_i2c_connector(struct radeonfb_info *rinfo, int conn,
u8 **out_edid)
{
- u32 reg = rinfo->i2c[conn-1].ddc_reg;
u8 *edid;
- OUTREG(reg, INREG(reg) &
- ~(VGA_DDC_DATA_OUTPUT | VGA_DDC_CLK_OUTPUT));
-
edid = fb_ddc_read(&rinfo->i2c[conn-1].adapter);
if (out_edid)
--
Jean Delvare
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
next reply other threads:[~2008-06-17 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 12:50 Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-06 9:21 [PATCH] radeonfb: Revert "Fix radeon DDC regression" Jean Delvare
2008-06-06 23:21 ` Benjamin Herrenschmidt
2008-07-31 8:59 ` Andrew Morton
2008-07-31 9:12 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617145040.55c5c088@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=adaplas@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).