* [PATCH 1/3] matrox maven: Fix a broken error path
@ 2008-06-17 18:00 Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2008-06-17 18:00 UTC (permalink / raw)
To: Petr Vandrovec; +Cc: linux-fbdev-devel
I broke an error path with d03c21ec0be7787ff6b75dcf56c0e96209ccbfbd,
sorry about that.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/video/matrox/matroxfb_maven.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.26-rc6.orig/drivers/video/matrox/matroxfb_maven.c 2008-06-17 17:22:42.000000000 +0200
+++ linux-2.6.26-rc6/drivers/video/matrox/matroxfb_maven.c 2008-06-17 17:23:18.000000000 +0200
@@ -1266,7 +1266,7 @@ static int maven_detect_client(struct i2
ERROR4:;
i2c_detach_client(new_client);
ERROR3:;
- kfree(new_client);
+ kfree(data);
ERROR0:;
return err;
}
--
Jean Delvare
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/3] matrox maven: Fix a broken error path
2008-08-08 14:49 [PATCH 0/3] matroxfb fixes and improvements Jean Delvare
@ 2008-08-08 14:58 ` Jean Delvare
2008-08-08 16:35 ` Krzysztof Helt
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2008-08-08 14:58 UTC (permalink / raw)
To: linux-fbdev-devel, Antonino Daplas; +Cc: Petr Vandrovec, LKML
I broke an error path with d03c21ec0be7787ff6b75dcf56c0e96209ccbfbd,
sorry about that.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/video/matrox/matroxfb_maven.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.26-rc6.orig/drivers/video/matrox/matroxfb_maven.c 2008-06-17 17:22:42.000000000 +0200
+++ linux-2.6.26-rc6/drivers/video/matrox/matroxfb_maven.c 2008-06-17 17:23:18.000000000 +0200
@@ -1266,7 +1266,7 @@ static int maven_detect_client(struct i2
ERROR4:;
i2c_detach_client(new_client);
ERROR3:;
- kfree(new_client);
+ kfree(data);
ERROR0:;
return err;
}
--
Jean Delvare
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] matrox maven: Fix a broken error path
2008-08-08 14:58 ` [PATCH 1/3] matrox maven: Fix a broken error path Jean Delvare
@ 2008-08-08 16:35 ` Krzysztof Helt
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Helt @ 2008-08-08 16:35 UTC (permalink / raw)
To: Jean Delvare, Andrew Morton
Cc: Petr Vandrovec, linux-fbdev-devel, LKML, Antonino Daplas
On Fri, 8 Aug 2008 16:58:23 +0200
Jean Delvare <khali@linux-fr.org> wrote:
> I broke an error path with d03c21ec0be7787ff6b75dcf56c0e96209ccbfbd,
> sorry about that.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> drivers/video/matrox/matroxfb_maven.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.26-rc6.orig/drivers/video/matrox/matroxfb_maven.c 2008-06-17 17:22:42.000000000 +0200
> +++ linux-2.6.26-rc6/drivers/video/matrox/matroxfb_maven.c 2008-06-17 17:23:18.000000000 +0200
> @@ -1266,7 +1266,7 @@ static int maven_detect_client(struct i2
> ERROR4:;
> i2c_detach_client(new_client);
> ERROR3:;
> - kfree(new_client);
> + kfree(data);
> ERROR0:;
> return err;
> }
>
>
> --
> Jean Delvare
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
>
----------------------------------------------------------------------
Tylko dla detektywow! Konkurs na Smaker.pl
Kliknij >>> http://link.interia.pl/f1eb1
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-08 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-17 18:00 [PATCH 1/3] matrox maven: Fix a broken error path Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2008-08-08 14:49 [PATCH 0/3] matroxfb fixes and improvements Jean Delvare
2008-08-08 14:58 ` [PATCH 1/3] matrox maven: Fix a broken error path Jean Delvare
2008-08-08 16:35 ` Krzysztof Helt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).