From: Sam Ravnborg <sam@ravnborg.org>
To: JosephChan@via.com.tw
Cc: geert@linux-m68k.org, akpm@linux-foundation.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/13] viafb: Makefile, share.h
Date: Mon, 30 Jun 2008 12:47:53 +0200 [thread overview]
Message-ID: <20080630104753.GA16040@uranus.ravnborg.org> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB8074E786A@exchtp03.taipei.via.com.tw>
On Mon, Jun 30, 2008 at 03:38:52PM +0800, JosephChan@via.com.tw wrote:
> Makefile for drivers/video/via/
> share.h: shared macro for viafb
>
>
> Signed-off-by: Joseph Chan <josephchan@via.com.tw>
>
> diff -Nur a/drivers/video/via/Makefile b/drivers/video/via/Makefile
> --- a/drivers/video/via/Makefile 1970-01-01 08:00:00.000000000 +0800
> +++ b/drivers/video/via/Makefile 2008-06-30 08:53:33.000000000 +0800
> @@ -0,0 +1,9 @@
> +#
> +# Makefile for the VIA framebuffer driver (for Linux Kernel 2.6)
> +#
> +
> +obj-$(CONFIG_FB_VIA) += viafb.o
> +
> +viafb-y :=viafbdev.o hw.o iface.o via_i2c.o dvi.o lcd.o ioctl.o accel.o via_utility.o vt1636.o global.o tblDPASetting.o viamode.o tbl1636.o
> +
> +viafb-objs := $(viafb-y)
This assignmnet is not needed - please drop it.
kbuild already understands <modulename>-y
Sam
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
next prev parent reply other threads:[~2008-06-30 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 7:38 [PATCH 9/13] viafb: Makefile, share.h JosephChan
2008-06-30 10:47 ` Sam Ravnborg [this message]
2008-07-01 1:14 ` JosephChan
2008-08-08 10:16 ` [PATCH 9/13 v2] " JosephChan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630104753.GA16040@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=JosephChan@via.com.tw \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).