Re: [PATCH v3] video: sh7760fb: SH7760/SH7763 LCDC framebuffer driver

[Manuel Lauss <mano@roarinelk.homelinux.net>]

Hello Paul, Iwamatsu-san,

On Tue, Jul 01, 2008 at 05:00:06PM +0900, Paul Mundt wrote:
> On Tue, Jul 01, 2008 at 04:26:11PM +0900, Nobuhiro Iwamatsu wrote:
> > +static void sh7760fb_wait_vsync(struct fb_info *info)
> > +{
> > +	struct sh7760fb_par *par = info->par;
> > +
> > +	if (par->pd->novsync)
> > +		return;
> > +}
> > +
> This doesn't do anything, and you never use ->novsync for anything
> anywhere else either. I'd suggest killing both of them off until such a
> time that you plan to do something with it.

I'm working on reimplementing it. I'll submit a patch when it's ready.

 
> > +	/* poll for access grant */
> > +	tmo = 100;
> > +	while (!(ioread16(par->base + LDPALCR) & (1 << 4)) && (--tmo))
> > +		msleep(0);
> > +
> Err.. you are sleeping for 0ms? Just use cpu_relax() here instead if you
> don't have an explicit timing requirement.

I put the msleep here to prevent gcc from removing the loop.


Best regards,
	Manuel Lauss

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php