From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: JosephChan@via.com.tw
Cc: geert@linux-m68k.org, akpm@linux-foundation.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h
Date: Tue, 1 Jul 2008 08:59:06 +0100 [thread overview]
Message-ID: <20080701085906.21688d20@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB8074E7D07@exchtp03.taipei.via.com.tw>
On Tue, 1 Jul 2008 09:20:31 +0800
<JosephChan@via.com.tw> wrote:
> Alan,
>
> Thanks to remind.
> Is it good to add viafb_ , ex: viafb_get_memsize(void)?
> It would be great to have your comment. Thanks again.
It is yes - that way global symbols don't clash between modules
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
next prev parent reply other threads:[~2008-07-01 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 7:26 [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h JosephChan
2008-06-30 9:39 ` Alan Cox
2008-07-01 1:20 ` JosephChan
2008-07-01 7:59 ` Alan Cox [this message]
2008-06-30 19:52 ` Jiri Slaby
2008-08-08 10:15 ` [PATCH 7/13 v2] " JosephChan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701085906.21688d20@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=JosephChan@via.com.tw \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).