From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ondrej Zajicek Subject: Re: [PATCH 6/7] drivers/video: Release mutex in error handling code Date: Tue, 22 Jul 2008 10:34:36 +0200 Message-ID: <20080722083436.GB10834@localhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1KLDKU-0003rY-IO for linux-fbdev-devel@lists.sourceforge.net; Tue, 22 Jul 2008 01:34:43 -0700 Received: from gateway.crfreenet.org ([81.92.146.254] helo=mail.crfreenet.org ident=postfix) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1KLDKT-0003nk-5V for linux-fbdev-devel@lists.sourceforge.net; Tue, 22 Jul 2008 01:34:42 -0700 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, adaplas@gmail.com On Mon, Jul 21, 2008 at 09:58:55AM +0200, Julia Lawall wrote: > From: Julia Lawall > > The mutex is released on a successful return, so it would seem that it > should be released on an error return as well. ... > Signed-off-by: Julia Lawall Acked-by: Ondrej Zajicek -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so." ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/