[PATCH] fix scrolling after logo is cleared

[PATCH] fix scrolling after logo is cleared

[Krzysztof Helt]

From: Krzysztof Helt <krzysztof.h1@wp.pl>

If the 'clear' command is used on the frame buffer
with a logo the upper area is filled by few lines but
not scrolled anymore.
Fix this by removing the protected area for the logo
if any part of the logo is cleared.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
---

diff -urp linux-rc2/drivers/video/console/fbcon.c linux-new/drivers/video/console/fbcon.c
--- linux-rc2/drivers/video/console/fbcon.c	2008-05-12 18:16:23.193553990 +0200
+++ linux-new/drivers/video/console/fbcon.c	2008-05-26 21:10:17.592997192 +0200
@@ -1312,6 +1310,9 @@ static void fbcon_clear(struct vc_data *
 	if (!height || !width)
 		return;
 
+	if (sy < vc->vc_top && vc->vc_top == logo_lines)
+		vc->vc_top = 0;
+
 	/* Split blits that cross physical y_wrap boundary */
 
 	y_break = p->vrows - p->yscroll;

----------------------------------------------------------------------
Tanie rozmowy!
Sprawdz >>> http://link.interia.pl/f1e13  


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: [PATCH] fix scrolling after logo is cleared

[Andrew Morton]

On Wed, 28 May 2008 22:53:37 +0200 Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:

> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> If the 'clear' command is used on the frame buffer
> with a logo the upper area is filled by few lines but
> not scrolled anymore.
> Fix this by removing the protected area for the logo
> if any part of the logo is cleared.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> ---
> 
> diff -urp linux-rc2/drivers/video/console/fbcon.c linux-new/drivers/video/console/fbcon.c
> --- linux-rc2/drivers/video/console/fbcon.c	2008-05-12 18:16:23.193553990 +0200
> +++ linux-new/drivers/video/console/fbcon.c	2008-05-26 21:10:17.592997192 +0200
> @@ -1312,6 +1310,9 @@ static void fbcon_clear(struct vc_data *
>  	if (!height || !width)
>  		return;
>  
> +	if (sy < vc->vc_top && vc->vc_top == logo_lines)
> +		vc->vc_top = 0;
> +
>  	/* Split blits that cross physical y_wrap boundary */
>  
>  	y_break = p->vrows - p->yscroll;
> 

So I'm trolling linux-fbdev-devel for lost patches and I come across
this one.

It is still good?  If so, do you think it should be in 2.6.27?  And
earlier?

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [PATCH] fix scrolling after logo is cleared

[krzysztof.h1]

> On Wed, 28 May 2008 22:53:37 +0200 Krzysztof Helt <krzysztof.h1@poczta.fm>
> wrote:
> 
> > From: Krzysztof Helt <krzysztof.h1@wp.pl>
> > 
> > If the 'clear' command is used on the frame buffer
> > with a logo the upper area is filled by few lines but
> > not scrolled anymore.
> > Fix this by removing the protected area for the logo
> > if any part of the logo is cleared.
> > 
> > Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> > ---
> > 
> > diff -urp linux-rc2/drivers/video/console/fbcon.c
> linux-new/drivers/video/console/fbcon.c
> > --- linux-rc2/drivers/video/console/fbcon.c	2008-05-12
> 18:16:23.193553990 +0200
> > +++ linux-new/drivers/video/console/fbcon.c	2008-05-26
> 21:10:17.592997192 +0200
> > @@ -1312,6 +1310,9 @@ static void fbcon_clear(struct vc_data *
> >  	if (!height || !width)
> >  		return;
> >  
> > +	if (sy < vc->vc_top && vc->vc_top == logo_lines)
> > +		vc->vc_top = 0;
> > +
> >  	/* Split blits that cross physical y_wrap boundary */
> >  
> >  	y_break = p->vrows - p->yscroll;
> > 
> 
> So I'm trolling linux-fbdev-devel for lost patches and I come across
> this one.
> 
> It is still good?  If so, do you think it should be in 2.6.27?  And
> earlier?
> 

I forgot this one. I sent it to get a feedback from other fbdev devs but forgot to resend it with cc to you.

Yes, it is  still good.  It is side effect of the tridentfb testing.

Regards,
Krzysztof

----------------------------------------------------------------------
Najciekawsze miejsca w Polsce i na swiecie!
Zobacz >>> http://link.interia.pl/f1e60


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/