* [PATCH] radeonfb: Give i2c buses nicer names
@ 2008-06-06 9:19 Jean Delvare
2008-06-06 9:21 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 7+ messages in thread
From: Jean Delvare @ 2008-06-06 9:19 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linux-fbdev-devel
The name of the i2c buses shows in the output of "i2cdetect -l", so
it's important to give informative names.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/video/aty/radeon_i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c 2008-06-03 09:57:31.000000000 +0200
+++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c 2008-06-06 08:43:51.000000000 +0200
@@ -69,7 +69,8 @@ static int radeon_setup_i2c_bus(struct r
{
int rc;
- strcpy(chan->adapter.name, name);
+ snprintf(chan->adapter.name, sizeof(chan->adapter.name),
+ "radeonfb %s", name);
chan->adapter.owner = THIS_MODULE;
chan->adapter.id = I2C_HW_B_RADEON;
chan->adapter.algo_data = &chan->algo;
--
Jean Delvare
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] radeonfb: Give i2c buses nicer names
2008-06-06 9:19 [PATCH] radeonfb: Give i2c buses nicer names Jean Delvare
@ 2008-06-06 9:21 ` Benjamin Herrenschmidt
2008-06-08 13:50 ` Jean Delvare
0 siblings, 1 reply; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2008-06-06 9:21 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-fbdev-devel
On Fri, 2008-06-06 at 11:19 +0200, Jean Delvare wrote:
> The name of the i2c buses shows in the output of "i2cdetect -l", so
> it's important to give informative names.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> drivers/video/aty/radeon_i2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c 2008-06-03 09:57:31.000000000 +0200
> +++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c 2008-06-06 08:43:51.000000000 +0200
> @@ -69,7 +69,8 @@ static int radeon_setup_i2c_bus(struct r
> {
> int rc;
>
> - strcpy(chan->adapter.name, name);
> + snprintf(chan->adapter.name, sizeof(chan->adapter.name),
> + "radeonfb %s", name);
> chan->adapter.owner = THIS_MODULE;
> chan->adapter.id = I2C_HW_B_RADEON;
> chan->adapter.algo_data = &chan->algo;
>
>
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] radeonfb: Give i2c buses nicer names
2008-06-06 9:21 ` Benjamin Herrenschmidt
@ 2008-06-08 13:50 ` Jean Delvare
2008-07-31 8:57 ` Andrew Morton
0 siblings, 1 reply; 7+ messages in thread
From: Jean Delvare @ 2008-06-08 13:50 UTC (permalink / raw)
To: benh; +Cc: linux-fbdev-devel
On Fri, 06 Jun 2008 19:21:37 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2008-06-06 at 11:19 +0200, Jean Delvare wrote:
> > The name of the i2c buses shows in the output of "i2cdetect -l", so
> > it's important to give informative names.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Hmm, does this mean that you won't take care of pushing the patch
upstream? Driver maintainers usually do that...
> > ---
> > drivers/video/aty/radeon_i2c.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > --- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c 2008-06-03 09:57:31.000000000 +0200
> > +++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c 2008-06-06 08:43:51.000000000 +0200
> > @@ -69,7 +69,8 @@ static int radeon_setup_i2c_bus(struct r
> > {
> > int rc;
> >
> > - strcpy(chan->adapter.name, name);
> > + snprintf(chan->adapter.name, sizeof(chan->adapter.name),
> > + "radeonfb %s", name);
> > chan->adapter.owner = THIS_MODULE;
> > chan->adapter.id = I2C_HW_B_RADEON;
> > chan->adapter.algo_data = &chan->algo;
> >
--
Jean Delvare
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] radeonfb: Give i2c buses nicer names
2008-06-08 13:50 ` Jean Delvare
@ 2008-07-31 8:57 ` Andrew Morton
2008-07-31 9:00 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2008-07-31 8:57 UTC (permalink / raw)
To: Jean Delvare; +Cc: benh, linux-fbdev-devel
On Sun, 8 Jun 2008 15:50:56 +0200 Jean Delvare <khali@linux-fr.org> wrote:
> On Fri, 06 Jun 2008 19:21:37 +1000, Benjamin Herrenschmidt wrote:
> > On Fri, 2008-06-06 at 11:19 +0200, Jean Delvare wrote:
> > > The name of the i2c buses shows in the output of "i2cdetect -l", so
> > > it's important to give informative names.
> > >
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> >
> > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Hmm, does this mean that you won't take care of pushing the patch
> upstream? Driver maintainers usually do that...
Tony hasn't been heard from in many months and I only very occasionally
troll linux-fbdev-devel for lost things.
Is this patch still good? If so, in which of
2.6.25/2.6.26/2.6.27/2.6.28 do you think it should be merged?
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] radeonfb: Give i2c buses nicer names
2008-07-31 8:57 ` Andrew Morton
@ 2008-07-31 9:00 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-31 9:00 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jean Delvare, linux-fbdev-devel
On Thu, 2008-07-31 at 01:57 -0700, Andrew Morton wrote:
> On Sun, 8 Jun 2008 15:50:56 +0200 Jean Delvare <khali@linux-fr.org> wrote:
>
> > On Fri, 06 Jun 2008 19:21:37 +1000, Benjamin Herrenschmidt wrote:
> > > On Fri, 2008-06-06 at 11:19 +0200, Jean Delvare wrote:
> > > > The name of the i2c buses shows in the output of "i2cdetect -l", so
> > > > it's important to give informative names.
> > > >
> > > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > >
> > > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >
> > Hmm, does this mean that you won't take care of pushing the patch
> > upstream? Driver maintainers usually do that...
>
> Tony hasn't been heard from in many months and I only very occasionally
> troll linux-fbdev-devel for lost things.
>
> Is this patch still good? If so, in which of
> 2.6.25/2.6.26/2.6.27/2.6.28 do you think it should be merged?
No objection here.
Ben.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] radeonfb: Give i2c buses nicer names
@ 2008-06-17 12:46 Jean Delvare
2008-06-18 18:57 ` Krzysztof Helt
0 siblings, 1 reply; 7+ messages in thread
From: Jean Delvare @ 2008-06-17 12:46 UTC (permalink / raw)
To: Antonino Daplas; +Cc: Benjamin Herrenschmidt, linux-fbdev-devel
The name of the i2c buses shows in the output of "i2cdetect -l", so
it's important to give informative names.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Antonino, can you please push this upstream? Thanks.
drivers/video/aty/radeon_i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c 2008-06-03 09:57:31.000000000 +0200
+++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c 2008-06-06 08:43:51.000000000 +0200
@@ -69,7 +69,8 @@ static int radeon_setup_i2c_bus(struct r
{
int rc;
- strcpy(chan->adapter.name, name);
+ snprintf(chan->adapter.name, sizeof(chan->adapter.name),
+ "radeonfb %s", name);
chan->adapter.owner = THIS_MODULE;
chan->adapter.id = I2C_HW_B_RADEON;
chan->adapter.algo_data = &chan->algo;
--
Jean Delvare
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] radeonfb: Give i2c buses nicer names
2008-06-17 12:46 Jean Delvare
@ 2008-06-18 18:57 ` Krzysztof Helt
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Helt @ 2008-06-18 18:57 UTC (permalink / raw)
To: linux-fbdev-devel
On Tue, 17 Jun 2008 14:46:15 +0200
Jean Delvare <khali@linux-fr.org> wrote:
> The name of the i2c buses shows in the output of "i2cdetect -l", so
> it's important to give informative names.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> Antonino, can you please push this upstream? Thanks.
>
Please send these patches to Andrew Morton.
Regards,
Krzysztof
----------------------------------------------------------------------
Backstage na The Police + bilet na koncert!
kliknij >>> http://link.interia.pl/f1e3d
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-07-31 9:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-06 9:19 [PATCH] radeonfb: Give i2c buses nicer names Jean Delvare
2008-06-06 9:21 ` Benjamin Herrenschmidt
2008-06-08 13:50 ` Jean Delvare
2008-07-31 8:57 ` Andrew Morton
2008-07-31 9:00 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2008-06-17 12:46 Jean Delvare
2008-06-18 18:57 ` Krzysztof Helt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).