Re: [Bugme-new] [Bug 11258] New: fbcon cursor disappered after switch to 512 consolefont

Re: [Bugme-new] [Bug 11258] New: fbcon cursor disappered after switch to 512 consolefont

[Andrew Morton]

(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Wed,  6 Aug 2008 08:27:54 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=11258
> 
>            Summary: fbcon cursor disappered after switch to 512 consolefont
>            Product: Drivers
>            Version: 2.5
>      KernelVersion: 2.6.26.1
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Console/Framebuffers
>         AssignedTo: jsimmons@infradead.org
>         ReportedBy: hanzelpeter@gmail.com
> 
> 
> Latest working kernel version: 2.6.25.8
> Earliest failing kernel version: 2.6.26
> Distribution: LFS 6.3
> Hardware Environment: VMWare 5.5
> Software Environment: LFS, framebuffer console
> Problem Description: When I use setfont to change font to 512 chars font, than
> blinking cursor disappers.
> 
> Steps to reproduce: 
> 1) setfont LatArCyrHeb-16.psfu.gz
> 2) press enter (sometimes twice or more)
> 3) blinking cursor disappers
> 4) start typing (no cursor)
> 5) press "backspace" => cursor is back
> 

A regression.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [Bugme-new] [Bug 11258] New: fbcon cursor disappered after switch to 512 consolefont

[Krzysztof Helt]

On Wed, 6 Aug 2008 09:12:04 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> 
> (switched to email.  Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
> 
> On Wed,  6 Aug 2008 08:27:54 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:
> 
> > http://bugzilla.kernel.org/show_bug.cgi?id=11258
> > 
> >            Summary: fbcon cursor disappered after switch to 512 consolefont

> 
> A regression.
> 


The patch for the issue is below. It is very similar to
Peter Hanzel's patch already posted to the bugzilla
but it honors vc_scrl_erase_char for scrolling.

Regards,
Krzysztof
----

From: Krzysztof Helt <krzysztof.h1@wp.pl>

Adjust  and honor the vc_scrl_erase_char for
256 and 512 character fonts.

It fixes the issue with disappearing cursor during scrolling
(kernel bug #11258). The issue was reported and tracked
by Peter Hanzel.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>

diff -urp linux-ref/drivers/video/console/fbcon.c linux-2.6.27/drivers/video/console/fbcon.c
--- linux-ref/drivers/video/console/fbcon.c	2008-08-09 19:00:06.000000000 +0200
+++ linux-2.6.27/drivers/video/console/fbcon.c	2008-08-09 19:04:44.000000000 +0200
@@ -2515,7 +2515,7 @@ static int fbcon_do_set_font(struct vc_d
 			c = vc->vc_video_erase_char;
 			vc->vc_video_erase_char =
 			    ((c & 0xfe00) >> 1) | (c & 0xff);
-			c = vc->vc_def_color;
+			c = vc->vc_scrl_erase_char;
 			vc->vc_scrl_erase_char =
 			    ((c & 0xFE00) >> 1) | (c & 0xFF);
 			vc->vc_attr >>= 1;
@@ -2548,7 +2548,7 @@ static int fbcon_do_set_font(struct vc_d
 			if (vc->vc_can_do_color) {
 				vc->vc_video_erase_char =
 				    ((c & 0xff00) << 1) | (c & 0xff);
-				c = vc->vc_def_color;
+				c = vc->vc_scrl_erase_char;
 				vc->vc_scrl_erase_char =
 				    ((c & 0xFF00) << 1) | (c & 0xFF);
 				vc->vc_attr <<= 1;


----------------------------------------------------------------------
Tylko dla detektywow! Konkurs na Smaker.pl
Kliknij >>> http://link.interia.pl/f1eb1


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/