[RFC] double buffering for atmel_lcdfb

[Stanislaw Gruszka <stf_xl@wp.pl>]

[-- Attachment #1: Type: text/plain, Size: 2102 bytes --]

Hello.

I try to implement double buffering for Atmel LCD display on AT91SAM9263 based 
board. I could not find any document about panning display on linux 
framebuffer, so I have some question about it and generic question about 
double buffer design. 

1) Is FBIOPAN_DISPLAY ioctl right way to implement double buffering?

2) What is the difference between ypanstep and ywrapstep, which one should be 
used for double buffering.

3) Does double buffer stuff should be turned on using module parameter, 
compile time parameter, board specific parameter (flag from platform device).
As it consume 2x memory I don't thing anyone want it by default.

I think double buffer for Atmel LCD should go mainline, of course after doing 
it reliable. After your comments and advice, I think I will be able to send 
right done and signed-off patch. 

Below is patch I have already done. I also attached program which I used for 
for tests - as far result are quite nice.

Cheers
Stanislaw Gruszka

diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index b004036..d0b2bed 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -7,7 +7,6 @@
  * License.  See the file COPYING in the main directory of this archive for
  * more details.
  */
-
 #include <linux/kernel.h>
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
@@ -41,6 +40,8 @@
 #if defined(CONFIG_ARCH_AT91)
 #define	ATMEL_LCDFB_FBINFO_DEFAULT	FBINFO_DEFAULT
 
+static int double_buffering = 1;
+
 static inline void atmel_lcdfb_update_dma2d(struct atmel_lcdfb_info *sinfo,
 					struct fb_var_screeninfo *var)
 {
@@ -789,7 +790,13 @@ static int __init atmel_lcdfb_probe(struct 
platform_device *pdev)
 		 * Don't clear the framebuffer -- someone may have set
 		 * up a splash image.
 		 */
+		double_buffering = 0;
+ 		dev_info(dev, "dissable double buffering\n");
 	} else {
+ 		if (double_buffering) {
+ 			info->fix.ypanstep = info->var.yres_virtual;
+ 			info->var.yres_virtual *= 2;
+		}
 		/* alocate memory buffer */
 		ret = atmel_lcdfb_alloc_video_memory(sinfo);
 		if (ret < 0) {

[-- Attachment #2: fbtest1.c --]
[-- Type: text/x-csrc, Size: 3216 bytes --]

#include <unistd.h>
#include <stdlib.h>
#include <stdio.h>
#include <fcntl.h>
#include <string.h>

#include <linux/fb.h>
#include <sys/mman.h>
#include <sys/ioctl.h>

int framebuffer_fd;
unsigned char *framebuffer_mem;
struct fb_var_screeninfo vinfo;
struct fb_fix_screeninfo finfo;

inline void perror_exit(char msg[])
{
	perror(msg);
	exit(1);
}

void draw_pixel(int x, int y, int r, int g, int b)
{
	unsigned int loc = (y+vinfo.yoffset) * finfo.line_length + (x+vinfo.xoffset) * vinfo.bits_per_pixel/8;
	unsigned char *ptr = framebuffer_mem;

	if (vinfo.bits_per_pixel == 16) {
		unsigned short pixel = r<<11 | g << 5 | b;
		*((unsigned int*)(ptr + loc)) = pixel;
     	} else if (vinfo.bits_per_pixel == 24) {
		*(ptr + loc + 0) = r;
		*(ptr + loc + 1) = g;
		*(ptr + loc + 2) = b;
	} else {
		fprintf(stderr, "Unsupported bits per pixel\n");
		exit(1);
	}
}

void blink_single_buf(void)
{
	unsigned int i, x, y;
	printf("Blinked screen with single buffer ... "); fflush(stdout);
	for (i = 0; i < 10; i++) {
		if (i & 1) {
			for (y = 0; y < vinfo.yres; y++)
        		for (x = 0; x < vinfo.xres; x++)
				draw_pixel(x, y, 0, 0, 31);
		} else {
			for (y = 0; y < vinfo.yres; y++)
        		for (x = 0; x < vinfo.xres; x++)
				draw_pixel(x, y, 31, 0, 0);
		}
		usleep(100*1000);
	}
	printf("done\n"); fflush(stdout);
}

void blink_double_buf(void)
{
	unsigned int i, x, y;
	printf("Blinked screen with double buffer ... "); fflush(stdout);
	for (i = 0; i < 10; i++) {
		if (vinfo.yoffset == vinfo.yres) {
			vinfo.yoffset = 0;
			for (y = 0; y < vinfo.yres; y++)
        		for (x = 0; x < vinfo.xres; x++)
				draw_pixel(x, y, 0, 0, 31);
    			if (ioctl(framebuffer_fd, FBIOPAN_DISPLAY, &vinfo))
				perror_exit("ioctl 1");
		} else {
			vinfo.yoffset = vinfo.yres;
			for (y = 0; y < vinfo.yres; y++)
        		for (x = 0; x < vinfo.xres; x++)
				draw_pixel(x, y, 31, 0, 0);
	    		if (ioctl(framebuffer_fd, FBIOPAN_DISPLAY, &vinfo))
				perror_exit("ioctl 2");
		}
		usleep(100*1000);
	}
	printf("done\n"); fflush(stdout);
}

int main(int argc, char *argv[])
{
	unsigned int scrsize;
	unsigned int x, y;
 
	framebuffer_fd = open("/dev/fb0", O_RDWR);
	if (!framebuffer_fd < 0)
        	perror_exit("open framebuffer device");

	if (ioctl(framebuffer_fd, FBIOGET_FSCREENINFO, &finfo))
       		perror_exit("ioctl(FBIOGET_FSCREENINFO)");

 	if (ioctl(framebuffer_fd, FBIOGET_VSCREENINFO, &vinfo))
        	perror_exit("ioctl(FBIOGET_VSCREENINFO)");
	
    	scrsize = vinfo.xres * vinfo.yres * vinfo.bits_per_pixel / 8;
    	printf("%dx%d virt(%dx%d), %dbpp, scrsize %u smem_len %u\n",
		vinfo.xres, vinfo.yres,
        	vinfo.xres_virtual, vinfo.yres_virtual,
		vinfo.bits_per_pixel, scrsize, finfo.smem_len);
	if (finfo.smem_len < 2*scrsize) {
		fprintf(stderr, "double buffering not supported by framebuffer!\n");
		return 1;
	}

	framebuffer_mem = (unsigned char *)mmap(0, finfo.smem_len,
						PROT_READ | PROT_WRITE, MAP_SHARED,
						framebuffer_fd, 0);
    	if ((long)framebuffer_mem == -1)
        	perror_exit("mmap");
    
    	for (y = 0; y < vinfo.yres; y++)
        for (x = 0; x < vinfo.xres; x++)
		draw_pixel(x, y, 0xff, 0xff, 0xff);

	blink_single_buf();
    	blink_double_buf();
	return 0;
}


[-- Attachment #3: Type: text/plain, Size: 363 bytes --]

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

[-- Attachment #4: Type: text/plain, Size: 182 bytes --]

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel