Re: [PATCH 2/2] tdfxfb: fix frame buffer name overrun

[krzysztof.h1@poczta.fm]

> On Wed, 27 Aug 2008, Krzysztof Helt wrote:
> > From: Krzysztof Helt <krzysztof.h1@wp.pl>
> > 
> > If there are more then one graphics card handled 
> > by the tdfxfb driver the name of the frame buffer 
> > overruns reserved name size.
> 
> Nice spot! Multiple strcat() will start overwriting other fields in
> fb_fix_screeninfo.
> 
> 
> At first I thought: but this doesn't fix all problems with multiple
> cards, as tdfx_fix is still shared among all of them? But that's not
> true (tdfx_fix is copied to info->fix later), so it is correct.
> 
> IMHO, as tdfx_fix is used as some `temporary' variable in tdfxfb_probe()
> only,
> a better fix would be to change the operation mode from:
> 
>     info = framebuffer_alloc(...);
>     tdfx_fix.foo = ...; /* depends on probe value */
>     tdfx_fix.bar = ...; /* depends on probe value */
>     info->fix = tdfx_fix;
> 
> to
> 
>     info = framebuffer_alloc(...);
>     info->fix = tdfx_fix;
>     info->fix.foo = ...; /* depends on probe value */
>     info->fix.bar = ...; /* depends on probe value */
> 
> and make tdfx_fix const. Then you don't have to initialize tdfx_fix.id
> for every card, and make it clear that tdfx_fix is just used as a
> template.
> 

Ok.

Andrew, please drop this patch. I will prepare next version (with signed-off-by as well). I started playing with git and I haven't notice that I need "-s" option while generating patches.

Regards,
Krzysztof


---------------------------------------------------------------
Nasilaja sie kradzieze.
Mieszkancy osiedli zaniepokojeni.
Prosimy o pomoc w tej sprawie >>> http://link.interia.pl/f1eef



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/