Re: [PATCH] i.MX Framebuffer: Cleanup Coding style

[Sascha Hauer <s.hauer@pengutronix.de>]

On Wed, Sep 03, 2008 at 09:19:17PM +0200, Krzysztof Helt wrote:
> On Tue,  2 Sep 2008 13:24:51 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  drivers/video/imxfb.c |   70 +++++++++++++++++++++++-------------------------
> >  1 files changed, 34 insertions(+), 36 deletions(-)
> > 
> 
> Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> One offtopic comment: do you really want the FBINFO_READS_FAST set?
> 
> It means that the driver prefer copyarea to imgblit function. It is
> usually slower on most drivers (opposite on chips with attached
> very fast memory: 3Dfx, GeForce, probably new ATI chips as well).
> 
> Please test your driver with and without this option if possible.

I'll keep that in mind and test it. I'm sure this flag never went in on
purpose, it went in with copy-paste.

Regards,
 Sascha

-- 
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/