From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rodolfo Giometti <giometti@enneenne.com>,
Eric Miao <eric.miao@marvell.com>,
linux-kernel@vger.kernel.org,
Rodolfo Giometti <giometti@linux.it>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] pxafb: frame buffer overlay support for PXA27x.
Date: Sat, 13 Sep 2008 11:20:33 +0100 [thread overview]
Message-ID: <20080913102033.GB24437@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080913030540.48341eae.akpm@linux-foundation.org>
On Sat, Sep 13, 2008 at 03:05:40AM -0700, Andrew Morton wrote:
> > +static int overlay1fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
> > +{
> > + struct overlayfb_info *fbi = (struct overlayfb_info *) info;
> > + unsigned long off = vma->vm_pgoff << PAGE_SHIFT;
> >
> > + if (off < info->fix.smem_len) {
> > + vma->vm_pgoff += fbi->video_offset / PAGE_SIZE;
> > + return dma_mmap_writecombine(o1_to_basefb(fbi)->dev, vma,
> > + fbi->map_cpu, fbi->map_dma,
> > + fbi->map_size);
> > + }
> > + return -EINVAL;
> > +}
>
> No need to set VM_IO or VM_RESERVED, etc?
That's covered by dma_mmap_writecombine -> remap_pfn_range:
vma->vm_flags |= VM_IO | VM_RESERVED | VM_PFNMAP;
prev parent reply other threads:[~2008-09-13 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1221034056-16587-1-git-send-email-giometti@enneenne.com>
[not found] ` <1221034056-16587-2-git-send-email-giometti@enneenne.com>
2008-09-13 10:05 ` [PATCH 1/2] pxafb: frame buffer overlay support for PXA27x Andrew Morton
2008-09-13 10:20 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080913102033.GB24437@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=eric.miao@marvell.com \
--cc=giometti@enneenne.com \
--cc=giometti@linux.it \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).