From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kristoffer Ericson Subject: Re: Allow more revisions in epson s1d13... driver Date: Mon, 29 Sep 2008 17:32:02 +0200 Message-ID: <20080929173202.1edd25e0.kristoffer.ericson@gmail.com> References: <20080929154735.a7cc4a29.kristoffer.ericson@gmail.com> <7d01f9f00809290803x603491e9w52891e767eade471@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.123] helo=mx.sourceforge.net) by 3yr0jf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1KkKjr-0003Z9-SO for linux-fbdev-devel@lists.sourceforge.net; Mon, 29 Sep 2008 15:32:43 +0000 Received: from ey-out-1920.google.com ([74.125.78.146]) by 3b2kzd1.ch3.sourceforge.com with esmtp (Exim 4.69) id 1KkKjl-0004VC-Vi for linux-fbdev-devel@lists.sourceforge.net; Mon, 29 Sep 2008 15:32:43 +0000 Received: by ey-out-1920.google.com with SMTP id 4so524752eyk.4 for ; Mon, 29 Sep 2008 08:32:35 -0700 (PDT) In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Geert Uytterhoeven Cc: akpm@linux-foundation.org, "linux-fbdev-devel@lists.sourceforge.net" , Thibaut VARENE On Mon, 29 Sep 2008 17:18:26 +0200 (CEST) Geert Uytterhoeven wrote: > On Mon, 29 Sep 2008, Thibaut VARENE wrote: > > On Mon, Sep 29, 2008 at 3:47 PM, Kristoffer Ericson > > wrote: > > > I've been trying to get someones attention to this patch. Currently the > > > file in question is without maintainer. > > > Ive however talked to Author Thiabaut Varene and adapted according > > > to his suggestions (he's cc'ed in this mail). > > > > This patch is a Ack from my side, save maybe for a tiny nitpick on the > > fact that I think s1d13xxxfb_revisions should be __devinitdata, but > > doing so seems to trigger compile issues. Haven't had time yet to dig > > that out. > > > > +static const int s1d13xxxfb_revisions[] = { > > > + S1D13506_CHIP_REV,/* Rev.4 on HP Jornada 7xx S1D13506 */ > > > + S1D13806_CHIP_REV /* Rev.7 on .. */ > > > +}; > > Does the compile issue go away if you use __devinitconst instead of > __devinitdata? > Yes, thanks for clearing that up. Going to resend with fixed also adding the ack. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kristoffer Ericson ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/