From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/4] cirrusfb: fix up debug printk types Date: Wed, 15 Oct 2008 16:05:20 -0700 Message-ID: <20081015160520.9ac1917a.akpm@linux-foundation.org> References: <20080905235312.ae259d60.krzysztof.h1@poczta.fm> <20080906121353.d6ed31c8.krzysztof.h1@poczta.fm> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.121] helo=mx.sourceforge.net) by 3yr0jf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1KqFRV-00015G-3n for linux-fbdev-devel@lists.sourceforge.net; Wed, 15 Oct 2008 23:06:13 +0000 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by 29vjzd1.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1KqFRP-0004Se-TU for linux-fbdev-devel@lists.sourceforge.net; Wed, 15 Oct 2008 23:06:13 +0000 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Geert Uytterhoeven Cc: linux-fbdev-devel@lists.sourceforge.net On Sat, 6 Sep 2008 12:41:14 +0200 (CEST) Geert Uytterhoeven wrote: > On Sat, 6 Sep 2008, Krzysztof Helt wrote: > > On Sat, 6 Sep 2008 10:37:27 +0200 (CEST) > > Geert Uytterhoeven wrote: > > > On Fri, 5 Sep 2008, Krzysztof Helt wrote: > > > > From: Krzysztof Helt > > > > > > > > Fix debug printk types mismatch after > > > > my earlier changes. > > > > > > #define DPRINTK(fmt, args...) pr_debug("%s: " fmt, __func__ , ## args) > > > > > > unconditionally, so you always catch these? > > > > > > > I do not understand. Is it a suggestion to make DPRINTK unconditional? > > Yes. > > > Then, the amount of information printed should be trimmed down. It is excessive now. > > Please not that pr_debug() gets optimized away if DEBUG is not defined > ( i.e. it doesn't cause excessive output), while it still performs > printf()-style format checking. > hm. No change occurred as a result of this discussion. I guess none was really needed - I'll go ahead with the patch. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/