From: Andrew Morton <akpm@linux-foundation.org>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Antonino Daplas <adaplas@gmail.com>,
Krzysztof Helt <krzysztof.h1@wp.pl>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH RESEND] vgacon: remember scrollback buffer on console switch
Date: Sat, 25 Oct 2008 16:14:56 -0700 [thread overview]
Message-ID: <20081025161456.643b36c6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081025224247.GA25497@joi>
On Sun, 26 Oct 2008 00:43:01 +0200 Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> PS: why DECLARE_MUTEX _defines_ _semaphore_?
The kernel gets definition-vs-declaration confused in several places.
> there are only 8 uses of this
> macro so it's not a big problem to rename it to e.g. DEFINE_SEMAPHORE (I can
> provide a patch)
I'd say that s/declare/define/ at such a late stage in the semaphore's
lifetime would be of dubious value. But getting "MUTEX" out of that
macro's name would be a very good thing - it's a bad overlap with struct
mutex. Send patch :)
next prev parent reply other threads:[~2008-10-25 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 19:58 [PATCH RESEND] vgacon: remember scrollback buffer on console switch Marcin Slusarz
2008-10-25 20:46 ` Andrew Morton
2008-10-25 22:43 ` Marcin Slusarz
2008-10-25 23:14 ` Andrew Morton [this message]
2008-10-29 14:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081025161456.643b36c6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=krzysztof.h1@wp.pl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).