From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>,
JosephChan@via.com.tw, linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix crash in viafb due to 4k stack overflow
Date: Sun, 9 Nov 2008 12:25:15 -0800 [thread overview]
Message-ID: <20081109122515.1deb9ec2@infradead.org> (raw)
In-Reply-To: <20081109113603.d45361ad.akpm@linux-foundation.org>
On Sun, 9 Nov 2008 11:36:03 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Sun, 9 Nov 2008 20:25:37 +0100 Bruno Pr__mont
> <bonbons@linux-vserver.org> wrote:
>
> > The function viafb_cursor() uses 2 stack-variables of CURSOR_SIZE
> > bits; CURSOR_SIZE is defined as (8 * 1024). Using up twice 1k on
> > stack is too much for 4k-stack (though it works with 8k-stacks).
>
> >
> > if (viacursor.enable)
>
> Is the ->fb_cursor handler allowed to perform GFP_KERNEL memory
> allocations? It's never called from atomic contexts?
if it's allowed to do GFP_KERNEL memory allocations the statement that
it works with 8k stacks is a bit overstated... since irq's can come in
and take several KB of stack as well ;)
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-11-09 20:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-09 19:25 [PATCH] Fix crash in viafb due to 4k stack overflow Bruno Prémont
2008-11-09 19:36 ` Andrew Morton
2008-11-09 20:25 ` Arjan van de Ven [this message]
2008-11-09 20:38 ` Bruno Prémont
2008-11-09 20:55 ` Andrew Morton
2008-11-09 21:37 ` Bruno Prémont
2008-11-09 22:57 ` Trent Piepho
2008-11-09 22:59 ` Andrew Morton
2008-11-10 21:00 ` Bruno Prémont
2008-11-12 23:01 ` Andrew Morton
2008-11-13 0:58 ` JosephChan
-- strict thread matches above, loose matches on Subject: below --
2008-11-14 8:41 JosephChan
2008-11-14 9:01 ` Bruno Prémont
2008-11-14 10:20 ` JosephChan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081109122515.1deb9ec2@infradead.org \
--to=arjan@infradead.org \
--cc=JosephChan@via.com.tw \
--cc=akpm@linux-foundation.org \
--cc=bonbons@linux-vserver.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).