linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: hvaibhav@ti.com
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-omap@vger.kernel.org
Subject: Re: [REVIEW PATCH] Added OMAP3EVM support on Tomis FBDEV/DSS Patches
Date: Fri, 14 Nov 2008 13:50:37 -0800	[thread overview]
Message-ID: <20081114215036.GQ3106@atomide.com> (raw)
In-Reply-To: <1226644352-22060-1-git-send-email-hvaibhav@ti.com>

* hvaibhav@ti.com <hvaibhav@ti.com> [081113 22:33]:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
> 
> Tested LCD, TV, DVI (480P) out on OMAP3EVM board.
> 
> Please make sure that you change the option
> CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE=7  and apply the
> Mans Rullgard clock patches to support set_rate and round_rate API.
> 
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c

> @@ -227,11 +430,13 @@ static void __init omap3_evm_init_irq(void)
> 
>  static struct omap_board_config_kernel omap3_evm_config[] __initdata = {
>  	{ OMAP_TAG_UART,	&omap3_evm_uart_config },
> -	{ OMAP_TAG_LCD,		&omap3_evm_lcd_config },
> +	{ OMAP_TAG_FBMEM,       &evm_fbmem0_config },
> +	{ OMAP_TAG_FBMEM,       &evm_fbmem1_config },
> +	{ OMAP_TAG_FBMEM,       &evm_fbmem2_config },
>  };
> 

Guys, please update your patches to remove the OMAP_TAG_FBMEM stuff
and rely on just platform_data. All the OMAP_TAGs will be disappearing
real soon now.

Tony

      parent reply	other threads:[~2008-11-14 21:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-14  6:32 [REVIEW PATCH] Added OMAP3EVM support on Tomis FBDEV/DSS Patches hvaibhav
2008-11-14 10:54 ` Tomi Valkeinen
2008-11-14 12:35   ` Hiremath, Vaibhav
2008-11-14 13:53     ` Hiremath, Vaibhav
2008-11-14 15:53     ` Tomi Valkeinen
2008-11-14 19:44       ` Koen Kooi
2008-11-15  8:45         ` Hiremath, Vaibhav
2008-11-18 12:09         ` Hiremath, Vaibhav
2008-11-18 12:21           ` Koen Kooi
2008-11-15  8:42       ` Hiremath, Vaibhav
2008-11-17  9:49         ` Tomi Valkeinen
2008-11-14 11:38 ` Koen Kooi
2008-11-14 11:49   ` Shah, Hardik
2008-11-14 21:50 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081114215036.GQ3106@atomide.com \
    --to=tony@atomide.com \
    --cc=hvaibhav@ti.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).