From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: ARM Linux <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/3] pxafb: allow pxafb_set_par() to start from arbitrary yoffset
Date: Wed, 17 Dec 2008 20:31:03 +0000 [thread overview]
Message-ID: <20081217203103.GD5864@flint.arm.linux.org.uk> (raw)
In-Reply-To: <f17812d70812170059j64f7130fi8131c6ad60642ec6@mail.gmail.com>
On Wed, Dec 17, 2008 at 04:59:00PM +0800, Eric Miao wrote:
> @@ -345,10 +343,9 @@ static int pxafb_check_var(struct
> fb_var_screeninfo *var, struct fb_info *info)
> return -EINVAL;
> }
>
> - var->xres_virtual =
> - max(var->xres_virtual, var->xres);
> - var->yres_virtual =
> - max(var->yres_virtual, var->yres);
> + var->xres_virtual = var->xres;
> + var->yres_virtual = fbi->fb.fix.smem_len /
> + (var->xres * var->bits_per_pixel / 8);
Previous experience of doing this with the X server and acornfb is that
it causes all sorts of problems - it seems to force the X server into
assuming that the framebuffer should be panned no matter what settings
you ask it for.
The recommended workaround (implemented in acornfb) is to only do these
kinds of adjustments if text mode acceleration is enabled. IIRC, the X
server should be disabling text mode acceleration when it maps the
framebuffer. I seem to remember that there are X servers which forget
to do that though.
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2008-12-17 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 8:59 [PATCH 2/3] pxafb: allow pxafb_set_par() to start from arbitrary yoffset Eric Miao
2008-12-17 20:31 ` Russell King - ARM Linux [this message]
2008-12-18 13:44 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217203103.GD5864@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).